[issue38192] Fix invocation of EchoClientProtocol

[Hrvoje Nikšić]

Change by Hrvoje Nikšić :


--
keywords: +patch
pull_requests: +15806
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16202

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38192] Fix invocation of EchoClientProtocol

[Hrvoje Nikšić]

New submission from Hrvoje Nikšić :

This is a followup on issue38178. While testing the new code, I noticed that my 
change introduced a bug, where the code still attempts to pass "loop" when 
constructing an EchoClientProtocol. A pull request is attached.

Also, I've noticed that the MyProtocol example under "Connecting Existing 
Sockets" is still passing an explicit loop, so I created a commit that converts 
it to the on_con_lost idiom, and included it in the above pull request.

--
assignee: docs@python
components: Documentation, asyncio
messages: 352584
nosy: asvetlov, docs@python, hniksic, yselivanov
priority: normal
severity: normal
status: open
title: Fix invocation of EchoClientProtocol
versions: Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38192] Fix invocation of EchoClientProtocol

[miss-islington]

Change by miss-islington :


--
pull_requests: +15820
pull_request: https://github.com/python/cpython/pull/16219

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38192] Fix invocation of EchoClientProtocol

[miss-islington]

miss-islington  added the comment:


New changeset 5d359cc62e0244e1fd8d17146a4135079d6843bf by Miss Islington (bot) 
(Hrvoje Nikšić) in branch 'master':
bpo-38192: Fix remaining passing of "loop" in the protocol examples (GH-16202)
https://github.com/python/cpython/commit/5d359cc62e0244e1fd8d17146a4135079d6843bf


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38192] Fix invocation of EchoClientProtocol

[miss-islington]

Change by miss-islington :


--
pull_requests: +15819
pull_request: https://github.com/python/cpython/pull/16218

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38192] Fix invocation of EchoClientProtocol

[miss-islington]

miss-islington  added the comment:


New changeset facbd316b409f3775da2a74d0845938b4c7b88f0 by Miss Islington (bot) 
in branch '3.7':
bpo-38192: Fix remaining passing of "loop" in the protocol examples (GH-16202)
https://github.com/python/cpython/commit/facbd316b409f3775da2a74d0845938b4c7b88f0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38192] Fix invocation of EchoClientProtocol

[miss-islington]

miss-islington  added the comment:


New changeset 1ba74719e3a213a2c473b92f3a79f8399e65f80a by Miss Islington (bot) 
in branch '3.8':
bpo-38192: Fix remaining passing of "loop" in the protocol examples (GH-16202)
https://github.com/python/cpython/commit/1ba74719e3a213a2c473b92f3a79f8399e65f80a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38192] Fix invocation of EchoClientProtocol

[Andrew Svetlov]

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com