[issue38957] Cannot compile with libffi from source on Windows

2019-12-02 Thread Ashley Whetter


Ashley Whetter  added the comment:

Ah you're right. I was trying to install in the same way as previous versions. 
I didn't realise that calling prepare_*.bat was a separate step now.
Sorry about that.

--
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38957] Cannot compile with libffi from source on Windows

2019-12-02 Thread Steve Dower


Steve Dower  added the comment:

The intent is that you'd build from source and then copy the binaries into the 
libffi directory (the *real* intent is that very few people should have to 
build libffi from source).

Can you tell us a bit more about what you were trying to achieve when you ran 
into this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38957] Cannot compile with libffi from source on Windows

2019-12-02 Thread Ashley Whetter


New submission from Ashley Whetter :

get_externals.bat downloads and extracts libffi to a versioned directory (much 
like the other external libraries). See 
https://github.com/python/cpython/blob/v3.8.0/PCbuild/get_externals.bat#L55
However the binary release is downloaded to an unversioned directory. See 
https://github.com/python/cpython/blob/v3.8.0/PCbuild/get_externals.bat#L79
The visual studio project looks for the unversioned directory 
(https://github.com/python/cpython/blob/v3.8.0/PCbuild/python.props#L62), and 
so the binaries are always used.

So it is possible to build from source, but you have to move libffi yourself 
after running `get_externals_bat --libffi-src`. I think the fix here is to make 
get_externals.bat and visual studio always use a versioned directory.

--
components: Build, Windows
messages: 357736
nosy: AWhetter, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Cannot compile with libffi from source on Windows
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com