[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:

Thanks Gaige Paulsen for the bug report, it's now fixed.

> I think GH-28612 broke Windows builds:

It was related to C++ build, it's now fixed by bpo-45893.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.11, Python 3.9 -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 92631a4144fba041a5fb6578620db784821dfdc5 by Victor Stinner in 
branch '3.9':
bpo-39026: Fix Python.h when building with Xcode (GH-29488) (GH-29776)
https://github.com/python/cpython/commit/92631a4144fba041a5fb6578620db784821dfdc5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +28013
pull_request: https://github.com/python/cpython/pull/29776

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:


New changeset ce5a6460aebdc51a810d2755782fe8f0d7918ec2 by Victor Stinner in 
branch '3.10':
bpo-39026: Fix Python.h when building with Xcode (GH-29488) (GH-29732)
https://github.com/python/cpython/commit/ce5a6460aebdc51a810d2755782fe8f0d7918ec2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +27971
pull_request: https://github.com/python/cpython/pull/29730

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[Christian Heimes]

Christian Heimes  added the comment:

I think GH-28612 broke Windows builds:

  python_uwp.cpp
python_uwp.obj : error LNK2001: unresolved external symbol 
"__declspec(dllimport) struct PyStatus __cdecl PyConfig_SetArgv(struct PyConfig 
*,__int64,wchar_t * const *)" 
(__imp_?PyConfig_SetArgv@@YA?AUPyStatus@@PEAUPyConfig@@_JPEBQEA_W@Z) 
[D:\a\1\s\PCbuild\python_uwp.vcxproj]
python_uwp.obj : error LNK2001: unresolved external symbol 
"__declspec(dllimport) int __cdecl PyStatus_Exception(struct PyStatus)" 
(__imp_?PyStatus_Exception@@YAHUPyStatus@@@Z) 
[D:\a\1\s\PCbuild\python_uwp.vcxproj]
python_uwp.obj : error LNK2001: unresolved external symbol 
"__declspec(dllimport) void __cdecl PyConfig_InitPythonConfig(struct PyConfig 
*)" (__imp_?PyConfig_InitPythonConfig@@YAXPEAUPyConfig@@@Z) 
[D:\a\1\s\PCbuild\python_uwp.vcxproj]
python_uwp.obj : error LNK2001: unresolved external symbol 
"__declspec(dllimport) int __cdecl PyStatus_IsExit(struct PyStatus)" 
(__imp_?PyStatus_IsExit@@YAHUPyStatus@@@Z) [D:\a\1\s\PCbuild\python_uwp.vcxproj]
python_uwp.obj : error LNK2001: unresolved external symbol 
"__declspec(dllimport) struct PyStatus __cdecl PyConfig_SetString(struct 
PyConfig *,wchar_t * *,wchar_t const *)" 
(__imp_?PyConfig_SetString@@YA?AUPyStatus@@PEAUPyConfig@@PEAPEA_WPEB_W@Z) 
[D:\a\1\s\PCbuild\python_uwp.vcxproj]
python_uwp.obj : error LNK2001: unresolved external symbol 
"__declspec(dllimport) void __cdecl PyConfig_Clear(struct PyConfig *)" 
(__imp_?PyConfig_Clear@@YAXPEAUPyConfig@@@Z) 
[D:\a\1\s\PCbuild\python_uwp.vcxproj]
python_uwp.obj : error LNK2001: unresolved external symbol 
"__declspec(dllimport) void __cdecl PyPreConfig_InitPythonConfig(struct 
PyPreConfig *)" (__imp_?PyPreConfig_InitPythonConfig@@YAXPEAUPyPreConfig@@@Z) 
[D:\a\1\s\PCbuild\python_uwp.vcxproj]
python_uwp.obj : error LNK2001: unresolved external symbol 
"__declspec(dllimport) struct PyStatus __cdecl PyStatus_Ok(void)" 
(__imp_?PyStatus_Ok@@YA?AUPyStatus@@XZ) [D:\a\1\s\PCbuild\python_uwp.vcxproj]
D:\a\1\s\PCbuild\amd64\python_uwp.exe : fatal error LNK1120: 8 unresolved 
externals [D:\a\1\s\PCbuild\python_uwp.vcxproj]

https://dev.azure.com/Python/cpython/_build/results?buildId=92032&view=results

--
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[Gaige Paulsen]

Gaige Paulsen  added the comment:

I can test the backports if you like. In that case, let me know when the 
backports are done, I should be able to test those rapidly, now that I have my 
build environment working for building from source.

Thanks again!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:

Gaige Paulsen: "Result: I can confirm that the compilation problem is resolved 
with this change (and was failing with the main branch prior to the change)."

Thank you for the confirmation. I merged my change and I'm backporting it to 
Python 3.9 and 3.10.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +27969
pull_request: https://github.com/python/cpython/pull/29732

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 4ae26b9c1d0c33e3db92c6f305293f9240dea358 by Victor Stinner in 
branch 'main':
bpo-39026: Fix Python.h when building with Xcode (GH-29488)
https://github.com/python/cpython/commit/4ae26b9c1d0c33e3db92c6f305293f9240dea358


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[Gaige Paulsen]

Gaige Paulsen  added the comment:

Sorry about the delay.
Finally fixed my workflow for building from scratch.

Result: I can confirm that the compilation problem is resolved with this change 
(and was failing with the main branch prior to the change).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[Gaige Paulsen]

Gaige Paulsen  added the comment:

Short version is not yet. I spent time on it but ran into an issue getting the 
full build on the machine I was building on. I expect to try it again before 
the weekend.

Is there a binary copy of the framework from the CI somewhere? If so, I can 
certainly do a much faster check against building with the framework, saving me 
the step I'm having problem with right now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:

Gaige Paulsen: "I'll try to check that in the next day or two."

Thanks. Did you have the opportunity to give it a try?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[Gaige Paulsen]

Gaige Paulsen  added the comment:

I'll try to check that in the next day or two.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:

I wrote a different fix: PR 29488. Can someone please check if it fix the issue 
with Xcode?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +27739
pull_request: https://github.com/python/cpython/pull/29488

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:

I propose to only rename header files in Python 3.11.

For Python 3.9 and 3.10, I suggest to modify Include/cpython/pystate.h by 
replacing:
  #include "cpython/initconfig.h"
with:
  #include "initconfig.h"

Like the PR 20181.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

STINNER Victor  added the comment:

I'm not sure why Include/cpython/ is part of the compiler include directories. 
I am not sure why Include/ is *not* part of the compiler include directory.

Anyway, it's hard to control how people build Python and there are always legit 
use cases where you fall into such issue.

That's why I suggest to fix any risk of confusion by renaming Include/cpython/ 
header files to add a "cpython_" prefix. For example, rename 
Include/cpython/pystate.h to Include/cpython/cpython_pystate.h.

In the Include/internal/ directory, header files already have a prefix for the 
exact same reason. For example, there is a pycore_pystate.h file there.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39026] Include/cpython/pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

[STINNER Victor]

Change by STINNER Victor :


--
title: pystate.h contains non-relative of initconfig.h include causing macOS 
Framework include failure -> Include/cpython/pystate.h contains non-relative of 
initconfig.h include causing macOS Framework include failure

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com