[issue39057] Issues with urllib.request.proxy_bypass_environment

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39057] Issues with urllib.request.proxy_bypass_environment

[miss-islington]

miss-islington  added the comment:


New changeset fc84d501b9d77701cbdd485de45e200bf027c0e9 by Miss Islington (bot) 
in branch '3.8':
bpo-39057: Fix urllib.request.proxy_bypass_environment(). (GH-17619)
https://github.com/python/cpython/commit/fc84d501b9d77701cbdd485de45e200bf027c0e9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39057] Issues with urllib.request.proxy_bypass_environment

[miss-islington]

miss-islington  added the comment:


New changeset 880a17af7d063fcef225a46b7f4ae35d792b2f11 by Miss Islington (bot) 
in branch '3.7':
bpo-39057: Fix urllib.request.proxy_bypass_environment(). (GH-17619)
https://github.com/python/cpython/commit/880a17af7d063fcef225a46b7f4ae35d792b2f11


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39057] Issues with urllib.request.proxy_bypass_environment

[miss-islington]

Change by miss-islington :


--
pull_requests: +17257
pull_request: https://github.com/python/cpython/pull/17830

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39057] Issues with urllib.request.proxy_bypass_environment

[miss-islington]

Change by miss-islington :


--
pull_requests: +17256
pull_request: https://github.com/python/cpython/pull/17829

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39057] Issues with urllib.request.proxy_bypass_environment

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 6a265f0d0c0a4b3b8fecf4275d49187a384167f4 by Serhiy Storchaka in 
branch 'master':
bpo-39057: Fix urllib.request.proxy_bypass_environment(). (GH-17619)
https://github.com/python/cpython/commit/6a265f0d0c0a4b3b8fecf4275d49187a384167f4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39057] Issues with urllib.request.proxy_bypass_environment

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +17089
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17619

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39057] Issues with urllib.request.proxy_bypass_environment

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

There are several issues with urllib.request.proxy_bypass_environment:

1. Leading dots are ignored in the proxy list, but not in the checked hostname. 
So ".localhost" does not matches ".localhost" in the proxy list.

2. A single trailing \n in the checked hostname is ignored, so "localhost\n" 
passes the check if the proxy list contains "localhost". But "localhost\n\n" 
and "localhost " do not pass. This is an artifact of using $ in the regular 
expression.

--
components: Library (Lib)
messages: 358444
nosy: orsenthil, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Issues with urllib.request.proxy_bypass_environment
type: behavior
versions: Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com