[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-30 Thread STINNER Victor

STINNER Victor [EMAIL PROTECTED] added the comment:

Close the issue since it's commited in 2.6 and 3.0. My patch 
configure-memory-debugger.patch is useless, a developer can fix 
obmalloc.c.

--
status: open - closed

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-24 Thread STINNER Victor

STINNER Victor [EMAIL PROTECTED] added the comment:

@loewis: your patch (revert.diff) includes a change in configure.in 
about OpenBSD !?

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-24 Thread Martin v. Löwis

Changes by Martin v. Löwis [EMAIL PROTECTED]:


Removed file: http://bugs.python.org/file11588/revert.diff

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-24 Thread Martin v. Löwis

Martin v. Löwis [EMAIL PROTECTED] added the comment:

Sorry about that - let me retry.

Added file: http://bugs.python.org/file11596/revert.diff

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-24 Thread Benjamin Peterson

Benjamin Peterson [EMAIL PROTECTED] added the comment:

Looks good to me.

--
keywords:  -needs review
nosy: +benjamin.peterson

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-24 Thread Martin v. Löwis

Martin v. Löwis [EMAIL PROTECTED] added the comment:

Committed as r66616 and r66617

--
assignee: loewis - 
priority: release blocker - normal

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-23 Thread STINNER Victor

New submission from STINNER Victor [EMAIL PROTECTED]:

In rev 56476, martin.v.loewis enabled Py_USING_MEMORY_DEBUGGER by 
default in an huge commit:
   PEP 3123: Provide forward compatibility with Python 3.0, 
   while keeping backwards compatibility. Add Py_Refcnt, 
   Py_Type, Py_Size, and PyVarObject_HEAD_INIT.

I guess that's an error, and that Py_USING_MEMORY_DEBUGGER should be 
disabled by default.

Proposition to avoid such bug in future: create a configure option, 
like --with-memory-debugger. See for example my patch to configure.in 
(you will need to run autoconf  autoheader).

--
files: configure-memory-debugger.patch
keywords: patch
messages: 73683
nosy: haypo
severity: normal
status: open
title: Disable Py_USING_MEMORY_DEBUGGER!
versions: Python 2.6, Python 3.0
Added file: http://bugs.python.org/file11583/configure-memory-debugger.patch

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-23 Thread STINNER Victor

Changes by STINNER Victor [EMAIL PROTECTED]:


Added file: http://bugs.python.org/file11584/obmalloc-no-debug.patch

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-23 Thread Benjamin Peterson

Changes by Benjamin Peterson [EMAIL PROTECTED]:


--
assignee:  - loewis
nosy: +loewis

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3951] Disable Py_USING_MEMORY_DEBUGGER!

2008-09-23 Thread Martin v. Löwis

Martin v. Löwis [EMAIL PROTECTED] added the comment:

You are right that this was by mistake; here is a patch to revert that
mistake (revert.diff).

I'm marking the issue release-critical because of thsi patch; the other
patches (for adding a new configure option) clearly can't go into 2.6,
and might need to be deferred to 2.7.

--
keywords: +needs review
priority:  - release blocker
Added file: http://bugs.python.org/file11588/revert.diff

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3951
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com