[issue39559] uuid.getnode() has unused argument

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I agree. It was added in issue32502, but was never documented and used.

Thank you Sebastian and Shantanu.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39559] uuid.getnode() has unused argument

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 8b6f6526f857bb7523b0fcff09b45bc6471289e9 by Shantanu in branch 
'master':
bpo-39559: Remove unused, undocumented argument from uuid.getnode (GH-18369)
https://github.com/python/cpython/commit/8b6f6526f857bb7523b0fcff09b45bc6471289e9


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39559] uuid.getnode() has unused argument

[Sebastian Rittau]

Sebastian Rittau  added the comment:

Code using this argument is in all likelihood already subtly broken, because it 
depends on non-existing functionality. I believe that a "hard" break would be 
better (for Python 3.9).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39559] uuid.getnode() has unused argument

[Shantanu]

Shantanu  added the comment:

Github code search isn't great, but I was unable to find any usage of 
`uuid.getnode(getters=`, whereas I was able to find usage of `uuid.uuid1(node=` 
(even though `node` is optional and can be passed positionally). I'd be 
surprised if it was used in practice, given that it's undocumented and only 
present on 3.7+ (I discovered it while running `inspect.signature` on large 
parts of stdlib). I think that, and the fact that this never did anything (even 
before bpo-28009 it looks like `getters` gets immediately overwritten), 
mitigate the risk here.

Let me know what you think should be done; happy to submit a PR that issues a 
deprecation warning.

--
nosy: +hauntsaninja

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39559] uuid.getnode() has unused argument

[Tal Einat]

Tal Einat  added the comment:

Simply removing the argument would be backwards-incompatible.

Unless someone can show via a code search that this is never used in practice, 
we may want to consider deprecating this argument before removing it.

--
nosy: +taleinat
versions: +Python 3.9 -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39559] uuid.getnode() has unused argument

[Shantanu]

Change by Shantanu :


--
keywords: +patch
pull_requests: +17743
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18369

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39559] uuid.getnode() has unused argument

[Sebastian Rittau]

Sebastian Rittau  added the comment:

Shantanu points out in https://github.com/python/typeshed/pull/3715 that the 
argument was made useless due to bpo-28009.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39559] uuid.getnode() has unused argument

[Sebastian Rittau]

New submission from Sebastian Rittau :

uuid.getnode() has an undocumented, keyword-only "getters" argument that gets 
discarded immediately. This is confusing when using code inspection tools and 
can give the wrong impression that you can somehow override the node getters 
when you can't. I recommend removing this argument.

--
components: Library (Lib)
messages: 361423
nosy: srittau
priority: normal
severity: normal
status: open
title: uuid.getnode() has unused argument
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com