[issue39868] Stale Python Language Reference docs (no walrus).

[Guido van Rossum]

Guido van Rossum  added the comment:

Congratulations SHANKAR JHA. Thank you for your contribution.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[miss-islington]

miss-islington  added the comment:


New changeset 616734b6c80e222f16249e9a9ce52588a0b611a7 by Miss Islington (bot) 
in branch '3.9':
bpo-39868: Add documentation for Assignment Expressions (walrus, PEP 572) 
(GH-18851)
https://github.com/python/cpython/commit/616734b6c80e222f16249e9a9ce52588a0b611a7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[miss-islington]

miss-islington  added the comment:


New changeset 755cb49429581679fc7b12905cb3d3ecf439032c by Miss Islington (bot) 
in branch '3.8':
bpo-39868: Add documentation for Assignment Expressions (walrus, PEP 572) 
(GH-18851)
https://github.com/python/cpython/commit/755cb49429581679fc7b12905cb3d3ecf439032c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[miss-islington]

Change by miss-islington :


--
pull_requests: +20764
pull_request: https://github.com/python/cpython/pull/21623

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[miss-islington]

Change by miss-islington :


--
pull_requests: +20763
pull_request: https://github.com/python/cpython/pull/21622

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset f117cef25b5ffc4db9fbe373ddb65e14f59f0397 by Shankar Jha in branch 
'master':
bpo-39868: Add documentation for Assignment Expressions (walrus, PEP 572) 
(#18851)
https://github.com/python/cpython/commit/f117cef25b5ffc4db9fbe373ddb65e14f59f0397


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

Change by SHANKAR JHA :


--
keywords: +patch
pull_requests: +18213
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18851

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

SHANKAR JHA  added the comment:

I have added the pull request: https://github.com/python/cpython/pull/18851. 
Please check it out and let me know if I need to change anything.

Thank you everyone for your guidance.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Brandt Bucher]

Brandt Bucher  added the comment:

> I have created my draft with an example but I am confused about where exactly 
> do I have to add the code and push it.

> I have cloned these two repositories in my system and setup everything:
> https://github.com/python/cpython
> https://github.com/python/devguide

Great! It's not necessary to clone the devguide though; CPython is the only one 
you're going to edit.

Make sure you've "forked" the repo on GitHub, and are working on a local clone 
of your fork. Otherwise things will be trickier.

> 1. Please tell me where I should be adding my code. Do I have to add code 
> here 
> https://github.com/python/cpython/blob/master/Doc/reference/expressions.rst 
> and push it?

Yes, you'll add the new documentation to line 1652, where the "TODO" comment 
is. You should make the changes in your own fork of the repo, and push. Then 
you'll be ready for a PR.

> 2. I am working on the master branch only. Is there any specific branch I 
> have to select?

Working from master in your own fork is fine, but frequent contributors often 
prefer to branch from master and work on those branches instead.

The pages I've linked to in the devguide walk you through every step of making 
a PR (including an intro on how to use Git). If it's easier for you, though, 
you can attach a copy of your edits to this issue and I can make a PR on your 
behalf. I just wouldn't count on repeating that workflow if you plan on 
contributing in the future; regular contributors should feel comfortable 
branching, committing, opening a PR, etc.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

SHANKAR JHA  added the comment:

I have created my draft with an example but I am confused about where exactly 
do I have to add the code and push it.

I have cloned these two repositories in my system and setup everything:
https://github.com/python/cpython
https://github.com/python/devguide

1. Please tell me where I should be adding my code. Do I have to add code here 
https://github.com/python/cpython/blob/master/Doc/reference/expressions.rst and 
push it?

2. I am working on the master branch only. Is there any specific branch I have 
to select?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Brandt Bucher]

Brandt Bucher  added the comment:

Great. Just replacing the TODO line with your new description (and maybe an 
example) should be perfect!

--
keywords:  -patch
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

SHANKAR JHA  added the comment:

I got it that I have to fill the "Assignment expression" section in the code. I 
am working on it and send you the for review once I am done.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

SHANKAR JHA  added the comment:

I am also checking your commit for this: 
(https://github.com/python/cpython/commit/8bae21962bab2fac7630982abd73676b89930902)
 and see that you are changing the "expression: to "assignment_expression". 

Do I have to fill what assignment expression does with some examples?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

SHANKAR JHA  added the comment:

Thank you for helping me out brandtbucher.

As per my understanding, I am looking into the code 
(https://github.com/python/cpython/blob/master/Doc/reference/expressions.rst) 
and finding where the code doesn't follow the pattern described in 
(https://www.python.org/dev/peps/pep-0572/.)

Please let me know if I am correct so that I will quickly go through everything 
and send you a pull request as soon as possible.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Brandt Bucher]

Brandt Bucher  added the comment:

Thanks for offering to help, Shankar! For this change, you can look at the 
other sections of the Doc/reference/expressions.rst file for an idea of what 
we're looking for. I think a few sentences and maybe a small code snippet 
should probably be fine.

The devguide has all of the information that you need to get started. 
Specifically, you'll want to look at:

- https://devguide.python.org/docquality/
- https://devguide.python.org/documenting/
- https://devguide.python.org/pullrequest/

Also, you should sign the CLA *as soon as possible* 
(https://www.python.org/psf/contrib/contrib-form/)!

Once you've made a PR, please request a review from me so I can make sure it 
moves along quickly. Let me know if you have any questions... I know it can be 
really tricky at first!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[miss-islington]

miss-islington  added the comment:


New changeset 0c717709c1b19b6f146b56db5f10bab3f09c by Miss Islington (bot) 
in branch '3.8':
bpo-39868: Update Language Reference for PEP 572. (GH-18793)
https://github.com/python/cpython/commit/0c717709c1b19b6f146b56db5f10bab3f09c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 8bae21962bab2fac7630982abd73676b89930902 by Brandt Bucher in 
branch 'master':
bpo-39868: Update Language Reference for PEP 572. (#18793)
https://github.com/python/cpython/commit/8bae21962bab2fac7630982abd73676b89930902


--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 5.0 -> 6.0
pull_requests: +18153
pull_request: https://github.com/python/cpython/pull/18797

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

SHANKAR JHA  added the comment:

This is my first contribution to Python. This is why I am looking for some 
guidance, just point me to some resource, and then I will look into it 
thoroughly.

I am reading this https://www.python.org/dev/peps/pep-0572/ for better 
understanding.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Brandt Bucher]

Brandt Bucher  added the comment:

Of course. After my PR is merged, you can make another PR that replaces the ".. 
TODO: BPO-39868" line with a description of how assignment expressions work. 
Likely much of the language can be borrowed from the PEP.

Let me know if you need help with any of the steps. Have you written RST / made 
a CPython PR on GitHub before?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

SHANKAR JHA  added the comment:

Thank you for that!!!

Can you please provide some pointers to what exactly I have to do?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Brandt Bucher]

Change by Brandt Bucher :


--
keywords: +patch
pull_requests: +18151
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18793

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Brandt Bucher]

Brandt Bucher  added the comment:

Sorry, I hadn't seen your comment... :(

I've already finished the grammar specification bit, but not the prose 
description of how assignment expressions work, etc.

How about I leave that empty in my PR and you can actually do the documentation 
part afterward that's merged? Cool? I'd be happy to review it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[SHANKAR JHA]

SHANKAR JHA  added the comment:

Can I take this issue?

--
nosy: +shankarj67

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39868] Stale Python Language Reference docs (no walrus).

[Brandt Bucher]

New submission from Brandt Bucher :

It looks like https://docs.python.org/3/reference/expressions.html and 
https://docs.python.org/3/reference/compound_stmts.html were never updated for 
named expressions.

Because this change has to be backported, it's sort of a blocker for my PEP 614 
doc updates in issue 39702, which need to use the missing node in 3.9 only (I'd 
rather have this get a clean backport now than a messy one later)!

Is somebody more familiar with PEP 572 willing to take this? Should be pretty 
straightforward.

Pinging Emily since it looks like you've done some grammar/doc work for this in 
the past.

--
assignee: docs@python
components: Documentation
keywords: easy
messages: 363456
nosy: brandtbucher, docs@python, emilyemorehouse
priority: normal
severity: normal
status: open
title: Stale Python Language Reference docs (no walrus).
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com