[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

Change by Barney Gale :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10 -Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset b913f47e87f788e705716ae037ee9f68b4265e69 by Miss Islington (bot) 
in branch '3.10':
bpo-39950: Fix deprecation warning in test for `pathlib.Path.link_to()` 
(GH-26155) (GH-26178)
https://github.com/python/cpython/commit/b913f47e87f788e705716ae037ee9f68b4265e69


--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[miss-islington]

Change by miss-islington :


--
pull_requests: +24801
pull_request: https://github.com/python/cpython/pull/26178

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[miss-islington]

Change by miss-islington :


--
pull_requests: +24792
pull_request: https://github.com/python/cpython/pull/26158

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

Change by Barney Gale :


--
pull_requests: +24789
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/26155

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

Change by Barney Gale :


--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

Change by Barney Gale :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

The changes have introduced deprecation warnings in tests. It seems 
https://github.com/python/cpython/blob/ad106c68eb00f5e4af2f937107baff6141948cee/Lib/test/test_pathlib.py#L1937
 is not covered.

./python -Wall -m test test_pathlib  
0:00:00 load avg: 0.81 Run tests sequentially
0:00:00 load avg: 0.81 [1/1] test_pathlib
/root/cpython/Lib/pathlib.py:1265: DeprecationWarning: pathlib.Path.link_to() 
is deprecated and is scheduled for removal in Python 3.12. Use 
pathlib.Path.hardlink_to() instead.
  warnings.warn("pathlib.Path.link_to() is deprecated and is scheduled "
/root/cpython/Lib/pathlib.py:1265: DeprecationWarning: pathlib.Path.link_to() 
is deprecated and is scheduled for removal in Python 3.12. Use 
pathlib.Path.hardlink_to() instead.
  warnings.warn("pathlib.Path.link_to() is deprecated and is scheduled "

== Tests result: SUCCESS ==

1 test OK.

Total duration: 2.9 sec
Tests result: SUCCESS

Also it will be nice to point to the line causing deprecation instead of the 
library soruce code that will help users identify the deprecated usage. Using 
stacklevel=2 might help here 
https://docs.python.org/3/library/warnings.html#warnings.warn


./python -Wall -m test test_pathlib  
0:00:00 load avg: 1.82 Run tests sequentially
0:00:00 load avg: 1.82 [1/1] test_pathlib
/root/cpython/Lib/test/test_pathlib.py:1937: DeprecationWarning: 
pathlib.Path.link_to() is deprecated and is scheduled for removal in Python 
3.12. Use pathlib.Path.hardlink_to() instead.
  q.link_to(r)
/root/cpython/Lib/test/test_pathlib.py:1937: DeprecationWarning: 
pathlib.Path.link_to() is deprecated and is scheduled for removal in Python 
3.12. Use pathlib.Path.hardlink_to() instead.
  q.link_to(r)

== Tests result: SUCCESS ==

1 test OK.

Total duration: 4.3 sec
Tests result: SUCCESS

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[miss-islington]

miss-islington  added the comment:


New changeset f24e2e5464ba6498e7b8d73c3f9b417d59fd1b26 by Barney Gale in branch 
'master':
bpo-39950: add `pathlib.Path.hardlink_to()` method that supersedes `link_to()` 
(GH-18909)
https://github.com/python/cpython/commit/f24e2e5464ba6498e7b8d73c3f9b417d59fd1b26


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

Barney Gale  added the comment:

I've logged bpo-42999 to cover fixing the existing `link_to()` docs issues. PR 
incoming...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Jay Chu]

Jay Chu  added the comment:

For me, and as you've pointed out, the current doc of `Path.link_to` is already 
wrong and misleading. Perhaps a fix of the doc should be made as a first step.

The doc uses the expression "Create a hard link pointing to a path named 
target." 
But comparing this to the doc of `Path.symlink_to`, which says "Make this path 
a symbolic link to target.", 
(and the doc of `os.link`, which says, "Create a hard link pointing to src 
named dst.",)
the current doc should actually be "Create a hard link at `target` pointing to 
this path." Sadly the argument name can't be changed here already.

And the doc of `Path.symlink_to` even have a helpful note: "Note: The order of 
arguments (link, target) is the reverse of os.symlink()’s." 
We could also add one for `Path.link_to`, too, like "Note: The order of 
arguments (link, target) is the consistent with os.link()’s.

Based on that foundation, we could finally continue to implement the correct 
"Path.hardlink_to". 

We can refer to how people retained `subprocess.call` while adding a newer , 
preferred `subprocess.run`, by noting people to prefer `Path.hardlink_to` as 
it's more consistent with the `pathlib` and OOP, along with telling them the 
obscurity of `Path.link_to` and why it's left here for backward capability.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

Barney Gale  added the comment:

Makes sense to me. Should I leave the documentation for `link_to` completely 
alone? With the addition of a similar function, I wonder if that may in itself 
cause confusion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Jay Chu]

Jay Chu  added the comment:

Maybe we could have the correct `Path.hardlink` implemented before removing or 
even deprecating the confusing `Path.link_to`? It will only help even if we 
don't remove the latter in a hurry.

--
nosy: +tothesong

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

Barney Gale  added the comment:

A question:

For my patch, I need to include a Python version where `Path.link_to()` will 
become unavailable. I'm not entirely sure how this should be determined. Some 
factors in play:

- `link_to()` was added in Python 3.8
- On github, I found these three repos which use `link_to()`:
  - https://github.com/akubera/pion-analysis
  - https://github.com/DailyDreaming/load-project
  - https://github.com/eight04/vpip

Can anyone suggest in which version of Python this function should be removed? 
Thanks.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

Change by Barney Gale :


--
keywords: +patch
pull_requests: +18321
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18909

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39950] Add pathlib.Path.hardlink_to()

[Barney Gale]

New submission from Barney Gale :

Per bpo-39291, the argument order for `pathlib.Path.link_to()` is inconsistent 
with `symlink_to()` and its own documentation.

This ticket covers adding a new `hardlink_to()` method with the correct 
argument order, and deprecating `link_to()`.

Discussion on python-dev: 
https://mail.python.org/archives/list/python-...@python.org/thread/7QPLYW36ZK6QTW4SV4FI6C343KYWCPAT/

--
components: Library (Lib)
messages: 364060
nosy: barneygale
priority: normal
severity: normal
status: open
title: Add pathlib.Path.hardlink_to()
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com