[issue39957] bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy around dict

[Inada Naoki]

Inada Naoki  added the comment:


New changeset 611836a69a7a98bb106b4d315ed76a1e17266f4f by Jens Reidel in branch 
'master':
bpo-39957: Change Signature.parameters to OrderedDict (GH-18988)
https://github.com/python/cpython/commit/611836a69a7a98bb106b4d315ed76a1e17266f4f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39957] bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy around dict

[Inada Naoki]

Change by Inada Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39957] bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy around dict

[Jens Reidel]

Change by Jens Reidel :


--
keywords: +patch
pull_requests: +18335
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18988

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39957] bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy around dict

[Inada Naoki]

Inada Naoki  added the comment:

Would you create a pull request?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39957] bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy around dict

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39957] bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy around dict

[Jens Reidel]

Jens Reidel  added the comment:

Just to show the types are inequal:

Without patch file:

>>> inspect.signature(lambda x: None).parameters
mappingproxy({'x': })

With patch file:

>>> inspect.signature(lambda x: None).parameters
mappingproxy(OrderedDict([('x', )]))

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39957] bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy around dict

[Jens Reidel]

Change by Jens Reidel :


--
title: bpo39775 not fixed - inspect.Signature.parameters still 
dict/mappingproxy -> bpo39775 not fixed - inspect.Signature.parameters still 
dict/mappingproxy around dict

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39957] bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy

[Jens Reidel]

New submission from Jens Reidel :

Hi guys,

compiling CPython from the master branch will result in a git history with the 
commit 
https://github.com/python/cpython/commit/211055176157545ce98e6c02b09d624719e6dd30
 included and in Lib/inspect.py, however the return type is still like before 
and behaviour has not changed.

Python 3.9.0a4+ (heads/master:be79373a78, Mar 11 2020, 16:36:27) 
[GCC 9.2.1 20190827 (Red Hat 9.2.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import inspect
>>> inspect.signature(lambda x, y: None).parameters == 
inspect.signature(lambda y, x: None).parameters
True
>>> 

I have been able to confirm this on all builds I've done. To get it to do 
expected behaviour and return False on above code, I need to patch back the 
commit that changed OrderedDict to dict 
(https://raw.githubusercontent.com/Gelbpunkt/python-image/master/inspect.patch 
is the file I am using to patch). I have compiled against the codebase of 
https://github.com/python/cpython/commit/be79373a78c0d75fc715ab64253c9b757987a848
 and believe this is some issue with the Lib/inspect.py code internally if the 
patch file can fix it.

--
components: Library (Lib)
messages: 364118
nosy: gelbpunkt
priority: normal
severity: normal
status: open
title: bpo39775 not fixed - inspect.Signature.parameters still dict/mappingproxy
type: behavior
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com