[issue40029] test_importlib.test_zip requires zlib but not marked

[Jason R. Coombs]

Jason R. Coombs  added the comment:

Thanks for the report and the fix.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40029] test_importlib.test_zip requires zlib but not marked

[Jason R. Coombs]

Jason R. Coombs  added the comment:


New changeset 15e5024d04fc89d948ae761d88048bc58a56b650 by Roman Yurchak in 
branch 'master':
bpo-40029 mark test_importlib.test_zip as requiring zlib (#19105)
https://github.com/python/cpython/commit/15e5024d04fc89d948ae761d88048bc58a56b650


--
nosy: +jaraco

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40029] test_importlib.test_zip requires zlib but not marked

[Roman Yurchak]

Change by Roman Yurchak :


--
keywords: +patch
nosy: +rth
nosy_count: 2.0 -> 3.0
pull_requests: +18465
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19105

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40029] test_importlib.test_zip requires zlib but not marked

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions: +Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40029] test_importlib.test_zip requires zlib but not marked

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +easy
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40029] test_importlib.test_zip requires zlib but not marked

[Karthikeyan Singaravelan]

New submission from Karthikeyan Singaravelan :

I was trying to compile and run tests on a fresh ubuntu 18.03 machine that 
didn't zlib. test_importlb.test_zip seems to have some tests that depend on 
zlib but not marked as such causing test errors. Like other tests these could 
be skipped zlib is not available using test.support.requires_zlib . Tests are 
as below : 

test_zip_version
test_zip_entry_points
test_case_insensitive
test_files

--
components: Tests
messages: 364727
nosy: brett.cannon, xtreak
priority: normal
severity: normal
status: open
title: test_importlib.test_zip requires zlib but not marked
type: behavior
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com