[issue40163] multissl doesn't support tarballs in /source/old/

[STINNER Victor]

STINNER Victor  added the comment:

Thanks for the fix!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[Christian Heimes]

Change by Christian Heimes :


--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[miss-islington]

miss-islington  added the comment:


New changeset 7a89f9b4e2c05a6abdf59e8a96a1fc80a47a1144 by Miss Islington (bot) 
in branch '3.7':
bpo-40163: Fix multissltest download of old OpenSSL (GH-19329)
https://github.com/python/cpython/commit/7a89f9b4e2c05a6abdf59e8a96a1fc80a47a1144


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[miss-islington]

miss-islington  added the comment:


New changeset fcea08059f46d2d9582bb7ce5b2e905b20b86e8e by Miss Islington (bot) 
in branch '3.8':
bpo-40163: Fix multissltest download of old OpenSSL (GH-19329)
https://github.com/python/cpython/commit/fcea08059f46d2d9582bb7ce5b2e905b20b86e8e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[Christian Heimes]

Change by Christian Heimes :


--
stage: patch review -> backport needed
versions:  -Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +19426
pull_request: https://github.com/python/cpython/pull/20122

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[miss-islington]

Change by miss-islington :


--
pull_requests: +19427
pull_request: https://github.com/python/cpython/pull/20123

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 938717fd04c53c717895a756d5910e8c8813706c by Christian Heimes in 
branch 'master':
bpo-40163: Fix multissltest download of old OpenSSL (GH-19329)
https://github.com/python/cpython/commit/938717fd04c53c717895a756d5910e8c8813706c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[STINNER Victor]

STINNER Victor  added the comment:

> talk to OpenSSL upstream.

Do you mean continue to provide old versions in /source/ directory as well? 
Maybe they move tarballs to /source/old/ on purpose, to force users to use the 
latest versions which get fixes for new vulnerabilities?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[Christian Heimes]

Christian Heimes  added the comment:

Benjamin, Larry,
The problem affects testing of security-only branches and 2.7.

--
components: +Tests
nosy: +benjamin.peterson, larry
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[Christian Heimes]

Change by Christian Heimes :


--
keywords: +patch
pull_requests: +18694
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19329

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[Christian Heimes]

Christian Heimes  added the comment:

Ah crap :/ That's annoying.

This breaks all CI of all our active branches and all open PRs. I'll fix the 
issue and talk to OpenSSL upstream.

--
assignee:  -> christian.heimes
versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[STINNER Victor]

STINNER Victor  added the comment:

When OpenSSL moves a tarball, all our pre-commit CIs are broken and suddenly, 
all PRs can no longer be merged. We have first write PRs to update the 
configuration of our CI to use the newer OpenSSL version, merge these PRs, and 
then *all* pending PRs must be rebased on top of these merged PRS to retrieve 
the newer CI configuration.

There are currently 1085 pending PRs at https://github.com/python/cpython/pulls 
Well, for most of them, the CI already passed so we can merge them. But if a 
reviewer requires changes, the CI will re-run and then fail :-(

Moreover, fixing multissltests.py doesn't help neither, since again, PRs should 
be rebased to retrieve multissltests.py changes.

I hope that I'm wrong and the situation is not so bad.

--

Another solution would be to enhance our workflow to always rebase PRs on the 
development branch. Something like what https://mergify.io/ does.

I'm not sure what is the configuration of Azure Pipelines, GitHub actions and 
Travis CI. Would it be possible to make them rebase the PRs before running 
tests.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40163] multissl doesn't support tarballs in /source/old/

[STINNER Victor]

New submission from STINNER Victor :

Tools/ssl/multissltests.py expects to find OpenSSL tarballs in:
https://www.openssl.org/source/

Like: https://www.openssl.org/source/openssl-1.1.1f.tar.gz

Problem: OpenSSL moves old versions to https://www.openssl.org/source/old/

If Tools/ssl/multissltests.py fails to download a tarball (HTTP error 404), it 
should try to get it from /source/old/.

It would prevent us to have to upgrade OpenSSL version immediately in all 
Python branches of all CIs (Azure Pipelines and Travis CI) as soon as OpenSSL 
decides to move a tarball. This move is not under our control.

Upgrading OpenSSL is a good practice. Breaking our CI is not :-)

--
components: Demos and Tools
messages: 365654
nosy: christian.heimes, vstinner
priority: normal
severity: normal
status: open
title: multissl doesn't support tarballs in /source/old/
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com