[issue40365] argparse: action "extend" with 1 parameter splits strings into characters

[Jonathan Haigh]

Jonathan Haigh  added the comment:

>> But I wonder, was this situation discussed in the original bug/issue?
>Doesn't look like it:

I was looking at the wrong PR link. This has more discussion: 
https://github.com/python/cpython/pull/13305.

nargs is discussed but I'm not sure it was realized that the nargs=None and 
nargs="?" cases would act in the way seen here rather than acting like append.

Having a default nargs of "+" was suggested but that suggestion was not 
addressed.

> I suggest that the default nargs for extend should be "*" or "+" and an 
> exception should be raised if nargs is given as "?".

I'm not convinced about that any more. Using append's behaviour is probably 
more reasonable for nargs=None and nargs="?".

--
nosy: +Anthony Sottile, BTaskaya, berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40365] argparse: action "extend" with 1 parameter splits strings into characters

[Jonathan Haigh]

Jonathan Haigh  added the comment:

The situation for type=int and unspecified nargs or nargs="?" is also 
surprising: 

Python 3.8.3 (default, May 21 2020, 12:19:36) 
[GCC 9.2.1 20191008] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import argparse
>>> p = argparse.ArgumentParser()
>>> p.add_argument("--c", action="extend", type=int)
_ExtendAction(option_strings=['--c'], dest='c', nargs=None, const=None, 
default=None, type=, choices=None, help=None, metavar=None)
>>> p.parse_args("--c 1".split())
Traceback (most recent call last):
  File "", line 1, in 
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1768, in parse_args
args, argv = self.parse_known_args(args, namespace)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1800, in parse_known_args
namespace, args = self._parse_known_args(args, namespace)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
2006, in _parse_known_args
start_index = consume_optional(start_index)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1946, in consume_optional
take_action(action, args, option_string)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1874, in take_action
action(self, namespace, argument_values, option_string)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1171, in __call__
items.extend(values)
TypeError: 'int' object is not iterable
>>> p = argparse.ArgumentParser()
>>> p.add_argument("--c", action="extend", type=int, nargs="?")
_ExtendAction(option_strings=['--c'], dest='c', nargs='?', const=None, 
default=None, type=, choices=None, help=None, metavar=None)
>>> p.parse_args("--c 1".split())
Traceback (most recent call last):
  File "", line 1, in 
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1768, in parse_args
args, argv = self.parse_known_args(args, namespace)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1800, in parse_known_args
namespace, args = self._parse_known_args(args, namespace)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
2006, in _parse_known_args
start_index = consume_optional(start_index)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1946, in consume_optional
take_action(action, args, option_string)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1874, in take_action
action(self, namespace, argument_values, option_string)
  File "/home/jonathan/.pyenv/versions/3.8.3/lib/python3.8/argparse.py", line 
1171, in __call__
items.extend(values)
TypeError: 'int' object is not iterable
>>>

I suggest that the default nargs for extend should be "*" or "+" and an 
exception should be raised if nargs is given as "?". I don't see the current 
behaviour with unspecified nargs or nargs="?" being useful (and it certainly is 
surprising). In both cases, I think the least surprising behaviour would be for 
extend to act the same as append (or for an exception to be raised).

> But I wonder, was this situation discussed in the original bug/issue?
Doesn't look like it:
https://bugs.python.org/issue23378
https://github.com/python/cpython/commit/aa32a7e1116f7aaaef9fec453db910e90ab7b101

--
nosy: +Jonathan Haigh

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40365] argparse: action "extend" with 1 parameter splits strings into characters

[paul j3]

paul j3  added the comment:

This is a consequence of Python's own definition of append vs extend

In [730]: alist = []
   
In [731]: alist.append('astring')   
   
In [732]: alist 
   
Out[732]: ['astring']
In [733]: alist.extend('astring')   
   
In [734]: alist 
   
Out[734]: ['astring', 'a', 's', 't', 'r', 'i', 'n', 'g']
In [735]: alist.extend(['astring']) 
   
In [736]: alist 
   
Out[736]: ['astring', 'a', 's', 't', 'r', 'i', 'n', 'g', 'astring']

Normally 'add_argument' doesn't check for valid parameters, but some Action 
subclasses do their own checking, 

'extend' inherits the nargs==0 test from 'append'. (extend just modifies the 
__call__, not the __init__ method.

But I wonder, was this situation discussed in the original bug/issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40365] argparse: action "extend" with 1 parameter splits strings into characters

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +paul.j3, rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40365] argparse: action "extend" with 1 parameter splits strings into characters

[strjan]

New submission from strjan :

When positional argument with action='extend' is given to parse only one string 
argument, the string is splitted into individual characters.

The problem occures, when no "nargs" is given; it makes sense that nargs is 
requiered, though at least notion in documentation would be nice, as the issue 
does not occure with action='append'

Minimal example included.

--
files: argparse_bug.py
messages: 367033
nosy: strjan
priority: normal
severity: normal
status: open
title: argparse: action "extend" with 1 parameter splits strings into characters
type: behavior
versions: Python 3.8, Python 3.9
Added file: https://bugs.python.org/file49086/argparse_bug.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com