[issue40385] Tools/checkpyc.py has been broken since PEP 552

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset f82807746d26b4c047f7f3115065f20bb63fb5ff by Ammar Askar in branch 
'master':
closes bpo-40385: Remove Tools/scripts/checkpyc.py (GH-19709)
https://github.com/python/cpython/commit/f82807746d26b4c047f7f3115065f20bb63fb5ff


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40385] Tools/checkpyc.py has been broken since PEP 552

[Ammar Askar]

Change by Ammar Askar :


--
keywords: +patch
pull_requests: +19030
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19709

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40385] Tools/checkpyc.py has been broken since PEP 552

[Benjamin Peterson]

Benjamin Peterson  added the comment:

I'd vote for axing it.

--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40385] Tools/checkpyc.py has been broken since PEP 552

[Ammar Askar]

New submission from Ammar Askar :

Looks like checkpyc.py has been broken since PEP 552 was implemented 
https://github.com/python/cpython/blob/0e80b561d442769631d66f1cc8813ac30f97378e/Tools/scripts/checkpyc.py#L44-L46

It fails to read the 4 bytes for the `flags` field nor does it handle hash 
based files. 

Considering it's been broken since 2017 and no one has complained, it might be 
safe to remove this particular script.

--
components: Demos and Tools
messages: 367250
nosy: ammar2
priority: normal
severity: normal
status: open
title: Tools/checkpyc.py has been broken since PEP 552
type: behavior
versions: Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com