[issue40640] Tutorial for Continue missing ... line

[Irit Katriel]

Irit Katriel  added the comment:

Thank you Chas!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Irit Katriel]

Irit Katriel  added the comment:


New changeset ada9cdb94158a101db65af17b62cdd2ae6c3e782 by Miss Islington (bot) 
in branch '3.9':
bpo-40640: doc -- add missing ... in example of Continue (GH-26055) (GH-26058)
https://github.com/python/cpython/commit/ada9cdb94158a101db65af17b62cdd2ae6c3e782


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Irit Katriel]

Irit Katriel  added the comment:


New changeset 48cb11bf5b426bd3f1d010f987c03115661261b7 by Miss Islington (bot) 
in branch '3.10':
bpo-40640: doc -- add missing ... in example of Continue (GH-26055) (GH-26057)
https://github.com/python/cpython/commit/48cb11bf5b426bd3f1d010f987c03115661261b7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[miss-islington]

Change by miss-islington :


--
pull_requests: +24698
pull_request: https://github.com/python/cpython/pull/26058

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 6.0 -> 7.0
pull_requests: +24697
pull_request: https://github.com/python/cpython/pull/26057

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +24695
pull_request: https://github.com/python/cpython/pull/26055

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Irit Katriel]

Irit Katriel  added the comment:

Chas - there is a conflict in the PR. Would you mind refreshing it? I'll try to 
make sure it gets merged this time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Irit Katriel]

Change by Irit Katriel :


--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Irit Katriel]

Irit Katriel  added the comment:

ping

--
nosy: +iritkatriel
versions:  -Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Chas Belov]

Chas Belov  added the comment:

@Florian Dahlitz, thank you for your help. I have created a PR at 
https://github.com/python/cpython/pull/20334 and it is awaiting approval of my 
CLA and of the change itself.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Chas Belov]

Change by Chas Belov :


--
keywords: +patch
pull_requests: +19602
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/20334

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Florian Dahlitz]

Florian Dahlitz  added the comment:

I pointed you to the quick guide. In fact, you fork the cpython repository, 
create a new branch called fix-issue-40640, change the file 
Doc/tutorial/controlflow.rst and submit a PR agains the cpython master branch. 
As Rahul as already added all the versions to the issue that need a backport, 
the cpython bot will handle it for you. So you only need to submit a PR to the 
master branch. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Chas Belov]

Chas Belov  added the comment:

@DahlitzFlorian: I'm happy do to the PR provided I don't actually have to build 
Python to work on a documentation change. If it does require building Python 
then please go ahead.

That said, I've looked at the Doc/tutorial/controlflow.rst and it appears to be 
a plain text file. I believe that I would have a PR up by May 26, 2020. Is the 
best practice to check out the 3.10 branch then add backport tags for the other 
versions to the PR? That wasn't clear to me from the docs you referred me to.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Florian Dahlitz]

Florian Dahlitz  added the comment:

Please go head @docor...@sonic.net! It's a good one to get familiar with the 
process of contributing. Yes, PR stands for Pull Request.

There is the devguide (https://devguide.python.org/), which documents how to 
contribute. In fact, the quick guide may be sufficient. Feel free to ask any 
further questions, I'm eager to help!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Chas Belov]

Chas Belov  added the comment:

Um, Python newcomer here. What's a PR? Pull request?

I'm happy to do it if you can point me to the how-to. I know my way around git, 
and not around Python community standards. 

You are also welcome to go ahead and make the change; thank you for asking.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Florian Dahlitz]

Florian Dahlitz  added the comment:

@docor...@sonic.net are you going to submit a PR for it or am I free to do it?

--
nosy: +DahlitzFlorian

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Rahul Kumaresan]

Rahul Kumaresan  added the comment:

I think the ommission of secondary prompt(...) at the end of the loop in the 
code snippet doesn't affect what the example wanted to demonstrate. Even so, if 
this has to be fixed, this correction is to be done in versions 3.5 through 3.10

--
versions: +Python 3.10, Python 3.5, Python 3.6, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Rahul Kumaresan]

Change by Rahul Kumaresan :


--
nosy: +rahul-kumi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40640] Tutorial for Continue missing ... line

[Chas Belov]

New submission from Chas Belov :

The tutorial code for Continue at 
https://docs.python.org/3.7/tutorial/controlflow.html#break-and-continue-statements-and-else-clauses-on-loops
 is missing a
...
null statement.

Actual code/result:

>>> for num in range(2, 10):
... if num % 2 == 0:
... print("Found an even number", num)
... continue
... print("Found a number", num)
Found an even number 2
Found a number 3
Found an even number 4
Found a number 5
Found an even number 6
Found a number 7
Found an even number 8
Found a number 9

Expected code/result:

>>> for num in range(2, 10):
... if num % 2 == 0:
... print("Found an even number", num)
... continue
... print("Found a number", num)
...
Found an even number 2
Found a number 3
Found an even number 4
Found a number 5
Found an even number 6
Found a number 7
Found an even number 8
Found a number 9

--
assignee: docs@python
components: Documentation
messages: 369014
nosy: docor...@sonic.net, docs@python
priority: normal
severity: normal
status: open
title: Tutorial for Continue missing ... line
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com