[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[miss-islington]

miss-islington  added the comment:


New changeset 3d062829deadcb8355e97090aba47138eb9bc649 by Miss Islington (bot) 
in branch '3.9':
bpo-40669: Use requirements.pip when installing PEG dependencies (GH-20194)
https://github.com/python/cpython/commit/3d062829deadcb8355e97090aba47138eb9bc649


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[miss-islington]

Change by miss-islington :


--
pull_requests: +19501
pull_request: https://github.com/python/cpython/pull/20203

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 3764069f3ba2a7e932837ae19265059339dc86e3 by Pablo Galindo in 
branch 'master':
bpo-40669: Use requirements.pip when installing PEG dependencies (GH-20194)
https://github.com/python/cpython/commit/3764069f3ba2a7e932837ae19265059339dc86e3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[STINNER Victor]

STINNER Victor  added the comment:

> bpo-40669: Install PEG benchmarking dependencies in a venv (GH-20183)

I like this approach :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19495
pull_request: https://github.com/python/cpython/pull/20194

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[miss-islington]

miss-islington  added the comment:


New changeset dc31800f86fbcd40ee616984820b885d8adaa6a7 by Lysandros Nikolaou in 
branch 'master':
bpo-40669: Install PEG benchmarking dependencies in a venv (GH-20183)
https://github.com/python/cpython/commit/dc31800f86fbcd40ee616984820b885d8adaa6a7


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19484
pull_request: https://github.com/python/cpython/pull/20183

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Lysandros Nikolaou]

Lysandros Nikolaou  added the comment:

> Doc/Makefile uses a virtual environment to install Sphinx and Sphinx 
> extensions. I suggest to do something similar.

I like this approach. Let me try it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[STINNER Victor]

STINNER Victor  added the comment:

Doc/Makefile uses a virtual environment to install Sphinx and Sphinx 
extensions. I suggest to do something similar.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Guido van Rossum]

Guido van Rossum  added the comment:

Soon nobody will remember to look at the memory stats at all. But I will review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Lysandros Nikolaou]

Lysandros Nikolaou  added the comment:

Because `make time` and all the related Makefile targets use the local built 
Python in the cpython parent directory. In order to install it, one would have 
to go through various steps, like installing openssl, configuring python with 
ssl support, building and installing python, creating a venv etc. Since it's 
more time-consuming that just running `make time` and since it's only needed 
for something that in most cases is not the most important thing, I think we 
can just go ahead and make it optional.

Is there a downside to this change I'm missing?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Guido van Rossum]

Guido van Rossum  added the comment:

Why not just install it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
keywords: +patch
pull_requests: +19471
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/20172

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40669] PEG Parser benchmarks fail if memory_profiler is not installed

[Lysandros Nikolaou]

New submission from Lysandros Nikolaou :

Running the PEG Parser benchmarks requires having memory_profiler installed.

In Tools/peg_generator:

➜  peg_generator git:(master) make time_stdlib
../../python -m zipfile -e data/xxl.zip data
../../python scripts/benchmark.py --parser=cpython --target=xxl compile
Traceback (most recent call last):
  File 
"/home/lysnikolaou/repos/cpython/Tools/peg_generator/scripts/benchmark.py", 
line 9, in 
import memory_profiler
ModuleNotFoundError: No module named 'memory_profiler'

I propose to make that optional and only compute the timing benchmarks, in case 
memory_profiler is not available, since it's these benchmarks that are most 
important and most frequently run.

--
assignee: lys.nikolaou
messages: 369204
nosy: gvanrossum, lys.nikolaou, pablogsal
priority: normal
severity: normal
status: open
title: PEG Parser benchmarks fail if memory_profiler is not installed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com