[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Feel free to re-open if i missed something :)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
versions:  -Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Given the status of the 3.9 branch and given that this does not add anything 
new or fixes any specific bug, I would recommend to not backport this

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 207c321f13cea3fee7f378057864e8c6453f5adf by Erlend Egeberg 
Aasland in branch 'master':
bpo-40744: Drop support for SQLite pre 3.7.3 (GH-20909)
https://github.com/python/cpython/commit/207c321f13cea3fee7f378057864e8c6453f5adf


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Łukasz, pinging you, since you are the release manager of 3.9.

Without PR 20909, 3.9 will be released without explicitly requiring SQLite 
3.7.3 (setup.py looks for SQLite >= 3.7.2), compiling python 3.9 against SQLite 
3.7.2 will fail at build time because of commit b9a0376, and it will also be 
possible to compile with SQLite 3.7.3 but run with pre SQLite 3.7.3 libraries, 
which could end up with a core dump.

With PR 20909, we explicitly state, in the docs, that SQLite 3.7.3 is required, 
and we explicitly check the SQLite version at configure time (setup.py), 
compile time (#ifdef => #error), and run time (if sqlite3_libversion_number() < 
...) to prevent CPython from being configured, build, or run against 
unsupported SQLite versions.

I might be overestimating the severity of this issue, but I thought you would 
be interested this, as the release manager of 3.9 :)

--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
pull_requests: +20091
pull_request: https://github.com/python/cpython/pull/20909

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
versions:  -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
pull_requests: +19598
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/20330

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40744] Explicitly drop support for SQLite version < 3.7.3

[Erlend Egeberg Aasland]

New submission from Erlend Egeberg Aasland :

Currently, we use sqlite3_create_function_v2() without wrapping it in any 
#ifdefs, so in practise the sqlite3 module will not build against sqlite3 pre 
3.7.3. Despite this, we still wrap parts of the code in #ifdefs for versions 
3.6.x and older.

Added patch drops support for sqlite3 pre 3.7.3.

--
components: Library (Lib)
files: 0001-Drop-support-for-sqlite3-3.7.3.patch
keywords: patch
messages: 369729
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: Explicitly drop support for SQLite version < 3.7.3
versions: Python 3.10, Python 3.8, Python 3.9
Added file: 
https://bugs.python.org/file49187/0001-Drop-support-for-sqlite3-3.7.3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com