[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset c8c818b0d73680516d5841597b705a1feeb42113 by Miss Islington (bot) 
in branch '3.7':
closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() 
(GH-21389)
https://github.com/python/cpython/commit/c8c818b0d73680516d5841597b705a1feeb42113


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[miss-islington]

miss-islington  added the comment:


New changeset 1d1c5743400bdf384ec83eb6ba5b39a355d121e3 by Miss Islington (bot) 
in branch '3.9':
closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() 
(GH-21385)
https://github.com/python/cpython/commit/1d1c5743400bdf384ec83eb6ba5b39a355d121e3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[miss-islington]

miss-islington  added the comment:


New changeset c8b599ff0a4e4782e97e353a20146d3570845dbc by Miss Islington (bot) 
in branch '3.8':
closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() 
(GH-21385)
https://github.com/python/cpython/commit/c8b599ff0a4e4782e97e353a20146d3570845dbc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[miss-islington]

Change by miss-islington :


--
pull_requests: +20535
pull_request: https://github.com/python/cpython/pull/21389

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[miss-islington]

Change by miss-islington :


--
pull_requests: +20534
pull_request: https://github.com/python/cpython/pull/21388

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset aebc0495572c5bb85d2bd97d27cf93ab038b5a6a by Zackery Spytz in 
branch 'master':
closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() 
(GH-21385)
https://github.com/python/cpython/commit/aebc0495572c5bb85d2bd97d27cf93ab038b5a6a


--
nosy: +benjamin.peterson
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +20533
pull_request: https://github.com/python/cpython/pull/21387

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +20530
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21385

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41235] Incorrect error handling in SSLContext.load_dh_params()

[Zackery Spytz]

New submission from Zackery Spytz :

If the SSL_CTX_set_tmp_dh() call fails, SSLContext.load_dh_params() returns
None with a live exception.  It should return NULL in this case.

--
assignee: christian.heimes
components: Extension Modules, SSL
messages: 373271
nosy: ZackerySpytz, christian.heimes
priority: normal
severity: normal
status: open
title: Incorrect error handling in SSLContext.load_dh_params()
type: behavior
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com