[issue41474] Missing dependency on Include/cpython/frameobject.h

[miss-islington]

miss-islington  added the comment:


New changeset 562ad7624e5fe22fdded9b39723c562255a49abd by Miss Skeleton (bot) 
in branch '3.9':
bpo-41474, Makefile: Add dependency on cpython/frameobject.h (GH-22999)
https://github.com/python/cpython/commit/562ad7624e5fe22fdded9b39723c562255a49abd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +21915
pull_request: https://github.com/python/cpython/pull/23000

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[STINNER Victor]

STINNER Victor  added the comment:


New changeset a6879d9445f98833c4e300e187956e2a218a2315 by Victor Stinner in 
branch 'master':
bpo-41474, Makefile: Add dependency on cpython/frameobject.h (GH-22999)
https://github.com/python/cpython/commit/a6879d9445f98833c4e300e187956e2a218a2315


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +21914
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22999

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Guido van Rossum]

Guido van Rossum  added the comment:

Wrong issue, sorry. (Bpo bug?)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Guido van Rossum]

Guido van Rossum  added the comment:

Sorry to rain on your parade, but couldn’t this be a new package on PyPI?

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Skip Montanaro]

Skip Montanaro  added the comment:

> > I don't know how to get rid of all those commit messages.
>
> I suggest you to create a local branch per change, rather than using "master".
>
> I consider that "origin" is g...@github.com:python/cpython.git. Check your 
> remotes with "git remote -v".

Hmmm... Seems like a bunch of extra work for a one-line change to a
Makefile... There's no easier way to create PRs for these trivial
changes?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[STINNER Victor]

STINNER Victor  added the comment:

> I don't know how to get rid of all those commit messages.

I suggest you to create a local branch per change, rather than using "master".

I consider that "origin" is g...@github.com:python/cpython.git. Check your 
remotes with "git remote -v".

Example where "master" is your PR 21732.

git switch -c frameobject master
git switch master
git reset --hard origin/master  # revert your changes

Then fix your frameobject:

git switch master
git fetch && git merge --ff  # ensure that you are up to date
git switch frameobject
git rebase master

Check what you get:

git log master.. --pretty=oneline

You should see only one commit.

Close your PR and create a new one on the "frameobject" branch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Skip Montanaro]

Skip Montanaro  added the comment:

> they all look to be of the form "Merge remote-tracking branch 
> 'upstream/master'".

Aside from one where I erroneously committed a change to the wrong
branch, then backed it out immediately.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Skip Montanaro]

Skip Montanaro  added the comment:

I see what @vstinner is talking about. If you look at those commit messages, 
they all look to be of the form "Merge remote-tracking branch 
'upstream/master'". That is, they are me syncing python/cpython/master to 
python/smontanaro/master. There is, in fact, just the one file changed, 
Makefile.pre.in, with the addition of a single dependency.

I don't know how to get rid of all those commit messages.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Skip Montanaro]

Skip Montanaro  added the comment:

> Your PR has 124 commits, that looks strange.

Funny, it told me just one file had changed (Makefile.pre.in). I was attempting 
to make a PR against that one change from my fork of master to the main repo. 
Let me take another crack at it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[STINNER Victor]

STINNER Victor  added the comment:

> Created a pull request. Hopefully I didn't muff the protocol too badly.

Your PR has 124 commits, that looks strange.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Skip Montanaro]

Skip Montanaro  added the comment:

Created a pull request. Hopefully I didn't muff the protocol too badly.

--
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Skip Montanaro]

Change by Skip Montanaro :


--
keywords: +patch
pull_requests: +20877
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21732

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41474] Missing dependency on Include/cpython/frameobject.h

[Skip Montanaro]

New submission from Skip Montanaro :

When Include/cpython/frameobject.h was created, there was no dependency added 
to Makefile.pre.in.

--
components: Build
messages: 374809
nosy: skip.montanaro
priority: normal
severity: normal
status: open
title: Missing dependency on Include/cpython/frameobject.h
type: compile error
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com