[issue41811] pstats.SortKey enum is broken

[Ethan Furman]

Change by Ethan Furman :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41811] pstats.SortKey enum is broken

[Ethan Furman]

Ethan Furman  added the comment:


New changeset 488e3eb70d24d5ce55ae0d7aed13a3721d3eb8a1 by Miss Islington (bot) 
in branch '3.8':
bpo-41811: create SortKey members using first given value (GH-22316) (GH-22326)
https://github.com/python/cpython/commit/488e3eb70d24d5ce55ae0d7aed13a3721d3eb8a1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41811] pstats.SortKey enum is broken

[Ethan Furman]

Ethan Furman  added the comment:


New changeset 0e4d526de47eae24b75f3623cd56bb0453fc8c74 by Miss Islington (bot) 
in branch '3.9':
bpo-41811: create SortKey members using first given value (GH-22316) (GH-22325)
https://github.com/python/cpython/commit/0e4d526de47eae24b75f3623cd56bb0453fc8c74


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41811] pstats.SortKey enum is broken

[Ethan Furman]

Ethan Furman  added the comment:


New changeset ae0d2a33ec05aece939a959d36fcf1df1e210a08 by Ethan Furman in 
branch 'master':
bpo-41811: create SortKey members using first given value (GH-22316)
https://github.com/python/cpython/commit/ae0d2a33ec05aece939a959d36fcf1df1e210a08


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41811] pstats.SortKey enum is broken

[miss-islington]

Change by miss-islington :


--
pull_requests: +21370
pull_request: https://github.com/python/cpython/pull/22326

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41811] pstats.SortKey enum is broken

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 1.0 -> 2.0
pull_requests: +21369
pull_request: https://github.com/python/cpython/pull/22325

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41811] pstats.SortKey enum is broken

[Ethan Furman]

Change by Ethan Furman :


--
keywords: +patch
pull_requests: +21361
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22316

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41811] pstats.SortKey enum is broken

[Ethan Furman]

New submission from Ethan Furman :

Currently, __new__ creates each member as an empty string, then adds the 
_value_ attribute.  Because of this, each member is equal to each other, and 
all appear the same to any data structure that relies on equality and hash as 
distinguishers (so, basically, all of them).

The fix is to use the first value as the string to be created.

--
assignee: ethan.furman
components: Library (Lib)
messages: 377153
nosy: ethan.furman
priority: normal
severity: normal
status: open
title: pstats.SortKey enum is broken
type: behavior
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com