[issue42043] zipfile.Path should support inheritance

[Étienne Pot]

New submission from Étienne Pot :

Currently, zipfile.Path inheritance behavior is inconsistent with pathlib.Path:

```
class MyPath(zipfile.Path):
  pass


path = MyPath(zf)
path = path.joinpath('other')
assert isinstance(path, MyPath)  # Oups, type(path) is zipfile.Path
```

Calling parent, /,... should keep the class, as for pathlib.Path

Use case: I'm writing a wrapper around `zipfile.Path` which adds `os.fspath` 
compatibility (the file is extracted in a tmp dir when os.path.join, open,...).

--
components: Library (Lib)
messages: 378678
nosy: Étienne Pot
priority: normal
severity: normal
status: open
title: zipfile.Path should support inheritance
type: enhancement
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42043] zipfile.Path should support inheritance

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
nosy: +python-dev
nosy_count: 1.0 -> 2.0
pull_requests: +21678
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22711

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42043] zipfile.Path should support inheritance

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +jaraco

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42043] zipfile.Path should support inheritance

[Jason R. Coombs]

Jason R. Coombs  added the comment:

This issue was addressed incidentally in 
[jaraco/zipp#56](https://github.com/jaraco/zipp/issues/56) released as zipp 
3.2.0.

I'd like to incorporate the tests submitted in PR 22711 and then port those 
changes to Python.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42043] zipfile.Path should support inheritance

[Jason R. Coombs]

Change by Jason R. Coombs :


--
pull_requests: +21684
pull_request: https://github.com/python/cpython/pull/22716

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42043] zipfile.Path should support inheritance

[Jason R. Coombs]

Jason R. Coombs  added the comment:


New changeset d1a0a960ee493262fb95a0f5b795b5b6d75cecb8 by Jason R. Coombs in 
branch 'master':
bpo-42043: Add support for zipfile.Path subclasses (#22716)
https://github.com/python/cpython/commit/d1a0a960ee493262fb95a0f5b795b5b6d75cecb8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42043] zipfile.Path should support inheritance

[Filipe Laíns]

Filipe Laíns  added the comment:

This can be closed now.

--
nosy: +FFY00

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42043] zipfile.Path should support inheritance

[Jason R. Coombs]

Change by Jason R. Coombs :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com