[issue42111] Make the xxlimited module an example of best extension module practices

[Petr Viktorin]

Change by Petr Viktorin :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[miss-islington]

miss-islington  added the comment:


New changeset c168b5078f88874b9acd993ac886f82269c780dd by Petr Viktorin in 
branch 'master':
bpo-42111: Make the xxlimited module an example of best extension module 
practices (GH-23226)
https://github.com/python/cpython/commit/c168b5078f88874b9acd993ac886f82269c780dd


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[Petr Viktorin]

Change by Petr Viktorin :


--
keywords: +patch
pull_requests: +22123
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23226

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[hai shi]

Change by hai shi :


--
nosy: +shihai1991

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[Petr Viktorin]

Change by Petr Viktorin :


--
assignee:  -> petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[Petr Viktorin]

Petr Viktorin  added the comment:

Thanks! That's my plan, but when I added tests I realized I need to pt in some 
general improvements to the stable ABI first.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I would interpret the limited pydev response (1 person, whose concern you 
incorporated into your post) to indicate absence of opposition.  Given that 384 
was written by someone inactive for years, I say go ahead and submit a PR for 
review by any interested active maintainers.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[Dong-hee Na]

Dong-hee Na  added the comment:

I am +1 on this idea.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[Dong-hee Na]

Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42111] Make the xxlimited module an example of best extension module practices

[Petr Viktorin]

New submission from Petr Viktorin :

The "xxlimited" module (Modules/xxlimited.c) was added as part of PEP 
384 (Defining a Stable ABI), and is undocumented. As far as I can tell, 
it was added partly to test the stable ABI, and partly as an example of 
how to write a module (like "xx" from xxmodule.c).
In the last few years the module has not seen much maintenance, and I 
believe it's no longer a good example to follow: it works, but there are 
now better ways to do things.

I would like to take over maintenance of the module and make it into an 
example of how to write a low-level C extension with isolated module 
state, as described in PEP 630 (Isolating Extension Modules) -- an 
informational PEP that I plan to convert to a HOWTO doc when everything 
is ready.

The old module will be kept around to test the 3.5 stable ABI.

Past discussion: 
https://mail.python.org/archives/list/python-...@python.org/thread/FO3YPG3YLG2XF5FKHICJHNINSPY4OHEL/#YITRQXGUOIEHK22QP5K4C5E45QA356U3

--
components: C API
messages: 379241
nosy: petr.viktorin
priority: normal
severity: normal
status: open
title: Make the xxlimited module an example of best extension module practices
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com