[issue42163] _replace() no longer works on platform.uname_result objects

[Jason R. Coombs]

Change by Jason R. Coombs :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Jason R. Coombs]

Jason R. Coombs  added the comment:


New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in 
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all 
but processor) (GH-23010) (#24232)
https://github.com/python/cpython/commit/799722cb0ddb90752cde7798cab543f30623ebf2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Jason R. Coombs]

Change by Jason R. Coombs :


--
pull_requests: +23055
pull_request: https://github.com/python/cpython/pull/24232

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Jason R. Coombs]

Jason R. Coombs  added the comment:


New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in 
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but 
processor) (#23010)
https://github.com/python/cpython/commit/a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Jason R. Coombs]

Jason R. Coombs  added the comment:

Please take a look at the PR. Let me know what you think about the limited 
compatibility it adds (still doesn't allow _replace on 'processor').

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Robert O'Callahan]

Robert O'Callahan  added the comment:

I filed issue 42189, which is similar but maybe worse: copy.deepcopy() is 
broken for platform.uname_result objects.

--
nosy: +rocallahan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Jason R. Coombs]

Change by Jason R. Coombs :


--
keywords: +patch
pull_requests: +21926
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23010

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Jason R. Coombs]

Jason R. Coombs  added the comment:

Indeed, it was unexpected that consumers of the `uname_result` were using 
`_replace`. In fact, the focus of the tests is on ensuring that users are able 
to access the items by index, e.g. `uname()[0]`.

It should be possible to support `_replace` on the `uname_result` as found in 
Python 3.9+. The real question is - is it important enough to declare and 
restore support for this use case based on this one report (and likely handful 
of other cases), or would it be better to discourage use of `_replace` for 
`uname_result` and provide a straightforward workaround (to be documented here) 
for those use-cases to employ?

Marc, do you have an opinion?

--
nosy: +lemburg -rhettinger
versions: +Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Jason R. Coombs]

Change by Jason R. Coombs :


--
assignee:  -> jaraco

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +jaraco, rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42163] _replace() no longer works on platform.uname_result objects

[Chandan Singh]

New submission from Chandan Singh :

Starting from Python 3.9, it seems like the `_replace()` method no longer  
works on `platform.uname_result` objects, that are returned by
`platform.uname()`. A simple example can be seen below, which works on Python 
3.8, but not on Python 3.9.

```
>>> import platform
>>> result = platform.uname()
>>> result._replace(machine="x86_64")
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/local/lib/python3.9/collections/__init__.py", line 448, in _replace
result = self._make(_map(kwds.pop, field_names, self))
  File "/usr/local/lib/python3.9/collections/__init__.py", line 441, in _make
raise TypeError(f'Expected {num_fields} arguments, got {len(result)}')
TypeError: Expected 5 arguments, got 6
```

I'm not sure if this is an intended change or an uninteded side-effect. The 
`_replace` method does work on simple namedtuple objects, and `uname_result` 
claims to be:

> largely compatible with a simple namedtumple` object except that 'platform' 
> is resolved late and cached to avoid calling "uname" except when needed`

This late resolution is what's new in Python 3.9 and also the source of the 
issue  as far as I can tell. I suppose the answer may depend on how braod our 
definition of  "largely compatible" is.

For some context, we use `_replace` in the tests of our BuildStream project, 
which is why we ran into this. The fix is reasonably simple on our end by 
changing how we mock some bits. But I wanted to check here if it's considered a 
bug or not. For reference, this is the patch we neded on our end: 
https://gitlab.com/BuildStream/buildstream/-/merge_requests/2092.

--
components: Library (Lib)
messages: 379694
nosy: cs-shadow
priority: normal
severity: normal
status: open
title: _replace() no longer works on platform.uname_result objects
type: behavior
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com