[issue42171] Add PEP 573 to the stable ABI

[Petr Viktorin]

Petr Viktorin  added the comment:

Added.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42171] Add PEP 573 to the stable ABI

[miss-islington]

miss-islington  added the comment:


New changeset 0b9c4c6fcf2b0673fa45ddfa092934a9d5479b8c by Petr Viktorin in 
branch 'master':
bpo-42171: Add PEP573-related items to the limited API (GH-23009)
https://github.com/python/cpython/commit/0b9c4c6fcf2b0673fa45ddfa092934a9d5479b8c


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42171] Add PEP 573 to the stable ABI

[hai shi]

Change by hai shi :


--
nosy: +shihai1991

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42171] Add PEP 573 to the stable ABI

[Petr Viktorin]

Change by Petr Viktorin :


--
keywords: +patch
pull_requests: +21925
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23009

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42171] Add PEP 573 to the stable ABI

[Petr Viktorin]

Petr Viktorin  added the comment:

Correction: PyModule_AddType is not from PEP 573. I'd like to add it anyway.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42171] Add PEP 573 to the stable ABI

[Dong-hee Na]

Dong-hee Na  added the comment:

> I'd like to add it anyway.
Nice ;)

--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42171] Add PEP 573 to the stable ABI

[Petr Viktorin]

New submission from Petr Viktorin :

The following PEP 573 were not added to the Windows list of stable ABI symbols 
(PC/python3dll.c):
- PyModule_AddType
- PyType_FromModuleAndSpec
- PyType_GetModule
- PyType_GetModuleState

I'd like to add them.

Also, the PEP introduces the (METH_FASTCALL | METH_KEYWORDS | METH_METHOD) 
calling convention, but METH_FASTCALL is not part of the stable ABI (and it 
other uses are not suitable for stable ABI).
I propose adding a new value, METH_METHOD_ARGS_KWD (name up for bikeshedding), 
which would be equal to (METH_FASTCALL | METH_KEYWORDS | METH_METHOD) but part 
of the limited API.

Does that sound like a good idea?


On the sprint, Steve mentioned that it would be possible to backport this to 
Python 3.9.1, even though it would mean a weird minor-version requirement.
I no longer think that's a good idea: fixing the stable ABI will be a 
longer-term project, and I don't want to fight issues in a 3.9 backport.

FWIW, for the longer-term project, I started a brainstorming repo at 
https://github.com/encukou/abi3 (Yes, it has some overlap with Victor's more 
general notes at https://pythoncapi.readthedocs.io/ )
But I'd like to get the additions above in to unblock #42111 before I start on 
improving the stable ABI in general.

--
components: C API
messages: 379762
nosy: ncoghlan, petr.viktorin, scoder, vstinner
priority: normal
severity: normal
status: open
title: Add PEP 573 to the stable ABI
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com