[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Change by Mark Shannon :


--
pull_requests: +23665
pull_request: https://github.com/python/cpython/pull/24902

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

PEP 626 deprecates co_lnotab, co_lnotab:

https://www.python.org/dev/peps/pep-0626/#id15

This doesn't seem to be mentioned in the What's new document and is quite 
important. Mark, do you mind creating a PR for this? I could do it and add you 
as a reviewer if you wish

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Change by Mark Shannon :


--
pull_requests: +23654
pull_request: https://github.com/python/cpython/pull/24892

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Mark Shannon  added the comment:

No. We should add it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Ned Batchelder]

Ned Batchelder  added the comment:

Is there a reason PEP 626 isn't yet mentioned in 
https://docs.python.org/3.10/whatsnew/3.10.html ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Change by Mark Shannon :


--
pull_requests: +23620
pull_request: https://github.com/python/cpython/pull/24860

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Neil Schemenauer]

Neil Schemenauer  added the comment:


New changeset 87ec26b812e9c4095c017dc60f246eda37b83ab2 by Neil Schemenauer in 
branch 'master':
bpo-43372: Use _freeze_importlib for regen-frozen. (GH-24759)
https://github.com/python/cpython/commit/87ec26b812e9c4095c017dc60f246eda37b83ab2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Neil Schemenauer]

Change by Neil Schemenauer :


--
pull_requests: +23532
pull_request: https://github.com/python/cpython/pull/24759

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Neil Schemenauer]

Change by Neil Schemenauer :


--
pull_requests: +23492
pull_request: https://github.com/python/cpython/pull/24714

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Neil Schemenauer]

Change by Neil Schemenauer :


--
nosy: +nascheme
nosy_count: 7.0 -> 8.0
pull_requests: +23485
pull_request: https://github.com/python/cpython/pull/24708

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Change by Mark Shannon :


--
pull_requests: +22923
pull_request: https://github.com/python/cpython/pull/24094

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Mark Shannon  added the comment:


New changeset 28b75c80dcc1e17ed3ac1c69362bf8dc164b760a by Mark Shannon in 
branch 'master':
bpo-42246: Don't eliminate jumps to jumps, if it will break PEP 626. (GH-23896)
https://github.com/python/cpython/commit/28b75c80dcc1e17ed3ac1c69362bf8dc164b760a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Batuhan Taskaya]

Change by Batuhan Taskaya :


--
nosy: +BTaskaya

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Change by Mark Shannon :


--
pull_requests: +22751
pull_request: https://github.com/python/cpython/pull/23896

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Inada Naoki]

Change by Inada Naoki :


--
nosy: +methane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Mark Shannon  added the comment:


New changeset bf353f3c2d937772a8cf30b15fd8eb7b82665ccb by Mark Shannon in 
branch 'master':
bpo-42246: Make sure that `f_lasti`, and thus `f_lineno`, is set correctly 
after raising or reraising an exception (GH-23803)
https://github.com/python/cpython/commit/bf353f3c2d937772a8cf30b15fd8eb7b82665ccb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Change by Mark Shannon :


--
pull_requests: +22663
pull_request: https://github.com/python/cpython/pull/23803

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Mark Shannon  added the comment:

https://github.com/python/cpython/pull/23780 fixes the finally handling.
The if-break case was fixed by earlier changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Mark Shannon  added the comment:


New changeset 8473cf89bdbf2cb292b39c972db540504669b9cd by Mark Shannon in 
branch 'master':
bpo-42246: Remove DO_NOT_EMIT_BYTECODE macros, so that while loops and if 
statements conform to PEP 626. (GH-23743)
https://github.com/python/cpython/commit/8473cf89bdbf2cb292b39c972db540504669b9cd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Mark Shannon]

Mark Shannon  added the comment:

Thanks Ned, that's really helpful. I'll go through those points:

Code after break/continue is no longer compiled.
Expected

First line number of modules
Expected

Except clause when no exception
https://bugs.python.org/issue42634

Double loops (this also covers End-of-loop jumps, I think)
https://bugs.python.org/issue42635

I want to merge https://github.com/python/cpython/pull/23743 before I fix any 
of the others, but here is a summary of what I think are the root causes.

if-break
Exit block duplication does not preserve line number of jump to final block

Finally handling
Combination of two things. Not preserving line numbers when performing 
jump-to-jump elimination and not marking try cleanup code as artificial.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Ned Batchelder]

Ned Batchelder  added the comment:

Mark, I'm categorizing and characterizing the test failures.  Here's the start 
of it: https://gist.github.com/nedbat/6c5dedde9df8d2de13de8a6a39a5f112  Let me 
know what other information would be useful.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

[Raymond Hettinger]

Change by Raymond Hettinger :


--
title: Implement PEP 626 -> Implement PEP 626 -- Precise line numbers for 
debugging

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com