[issue42392] remove the deprecated 'loop' parameter asyncio API

[Gregory P. Smith]

Change by Gregory P. Smith :


--
assignee:  -> docs@python
components: +Documentation
nosy: +docs@python

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42392] remove the deprecated 'loop' parameter asyncio API

[Gregory P. Smith]

Gregory P. Smith  added the comment:

There appear to be no versionchanged:: 3.10 in the asyncio docs on the APIs 
that formerly accepted a loop= parameter linking people to information on when 
that went away (3.10) and why.  Specifically I'm talking about 
https://docs.python.org/3.10/library/asyncio-stream.html.

The asyncio stack traces people will face when porting code to 3.10 are 
mystifying (they may not even show use of a loop parameter) when this comes up, 
so we should really leave more bread crumbs than expecting people to find the 
What's New doc.

```
...
Eserver = event_loop.run_until_complete(coro)
E  File 
"/opt/hostedtoolcache/Python/3.10.0-beta.1/x64/lib/python3.10/asyncio/base_events.py",
 line 641, in run_until_complete
Ereturn future.result()
E  File 
"/opt/hostedtoolcache/Python/3.10.0-beta.1/x64/lib/python3.10/asyncio/streams.py",
 line 113, in start_unix_server
Ereturn await loop.create_unix_server(factory, path, **kwds)
E  TypeError: _UnixSelectorEventLoop.create_unix_server() got an unexpected 
keyword argument 'loop'
```

Arguably something similar to that whatsnew text should've been added to the 
docs in 3.8 with the loop deprecation.  Something like this?

```
.. versionchanged:: 3.7

   This function now implicitly gets the
   current thread's running event loop.

.. versionchanged:: 3.10
   That `loop` parameter has been removed.
```

including a ReST link to more info in the whats new doc on the last entry would 
be useful.

--
nosy: +gregory.p.smith
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42392] remove the deprecated 'loop' parameter asyncio API

[miss-islington]

miss-islington  added the comment:


New changeset dcea78ff53d02733ac5983255610b651aa1c0034 by Ken Jin in branch 
'master':
bpo-42392: Mention loop removal in whatsnew for 3.10 (GH-24256)
https://github.com/python/cpython/commit/dcea78ff53d02733ac5983255610b651aa1c0034


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42392] remove the deprecated 'loop' parameter asyncio API

[Ken Jin]

Change by Ken Jin :


--
nosy: +kj
nosy_count: 5.0 -> 6.0
pull_requests: +23078
pull_request: https://github.com/python/cpython/pull/24256

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42392] remove the deprecated 'loop' parameter asyncio API

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Thanks for your help!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42392] remove the deprecated 'loop' parameter asyncio API

[Yurii Karabas]

Yurii Karabas <1998uri...@gmail.com> added the comment:

Looks like we have done everything, we can close this issue

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42392] remove the deprecated 'loop' parameter asyncio API

[Andrew Svetlov]

Andrew Svetlov  added the comment:


New changeset 86150d39c888579b65841f4391d054b7b3eff9f2 by Yurii Karabas in 
branch 'master':
bpo-42392: Remove deprecated loop parameter from docs (GH-23552)
https://github.com/python/cpython/commit/86150d39c888579b65841f4391d054b7b3eff9f2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42392] remove the deprecated 'loop' parameter asyncio API

[Yurii Karabas]

Change by Yurii Karabas <1998uri...@gmail.com>:


--
pull_requests: +22432
pull_request: https://github.com/python/cpython/pull/23552

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42392] remove the deprecated 'loop' parameter asyncio API

[Andrew Svetlov]

Change by Andrew Svetlov :


--
title: remove the 'loop' parameter from __init__ in all classes in 
asyncio.locks -> remove the deprecated 'loop' parameter asyncio API

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com