[issue42474] improve test coverage for TracebackException's __eq__

[Guido van Rossum]

Guido van Rossum  added the comment:

Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset d82e08d185d52086f4d921c08b853c76c80bebbe by Irit Katriel in 
branch '3.8':
[3.8] bpo-42474: test TracebackException comparison to non-equal instances 
(GH-23558)
https://github.com/python/cpython/commit/d82e08d185d52086f4d921c08b853c76c80bebbe


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 586bdd1add2ca7236e3096ab7167862cf17f0939 by Irit Katriel in 
branch '3.9':
[3.9] bpo-42474: test TracebackException comparison to non-equal instances 
(GH-23557)
https://github.com/python/cpython/commit/586bdd1add2ca7236e3096ab7167862cf17f0939


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +22440
pull_request: https://github.com/python/cpython/pull/23558

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Irit Katriel]

Irit Katriel  added the comment:

Yes.

I haven't managed to get the cherry-picker script working for me yet so this is 
a manual cherry-pick. 

I'm surprised the automatic backport failed - there was no merge conflict.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +22439
pull_request: https://github.com/python/cpython/pull/23557

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Guido van Rossum]

Guido van Rossum  added the comment:

Irit, can you,do the manual backports?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 44ca05afc89c9967f5dbc6c3ad89fc298c460e93 by Irit Katriel in 
branch 'master':
bpo-42474: test TracebackException comparison to non-equal instances (GH-23522)
https://github.com/python/cpython/commit/44ca05afc89c9967f5dbc6c3ad89fc298c460e93


--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Irit Katriel]

Change by Irit Katriel :


--
keywords: +patch
pull_requests: +22406
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23522

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42474] improve test coverage for TracebackException's __eq__

[Irit Katriel]

New submission from Irit Katriel :

Currently there are no tests for comparison between non-equal instances of 
traceback.TracebackException, so changing it's __eq__ to return True instead of 
self.__dict__ == other.__dict__ would not break any tests.

--
assignee: iritkatriel
components: Tests
messages: 381906
nosy: iritkatriel
priority: normal
severity: normal
status: open
title: improve test coverage for TracebackException's __eq__
type: enhancement
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com