[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[STINNER Victor]

STINNER Victor  added the comment:


New changeset f4507231e3f0cf8827cec5592571ce371c6813e8 by Victor Stinner in 
branch 'master':
bpo-42745: finalize_interp_types() calls _PyType_Fini() (GH-23953)
https://github.com/python/cpython/commit/f4507231e3f0cf8827cec5592571ce371c6813e8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[STINNER Victor]

STINNER Victor  added the comment:

> I assume PR 23953 fixes those?

Yes, it fix the 7 tests which leak:

./python -m test -R 3:3 -j0 test__xxsubinterpreters test_ast test_atexit 
test_capi test_interpreters test_threading

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

41010184880151d6ae02a226dbacc796e5c90d11 introduced some reference leaks:

https://buildbot.python.org/all/#/builders/384/builds/136

41010184880151d6ae02a226dbacc796e5c90d11 is the first bad commit
commit 41010184880151d6ae02a226dbacc796e5c90d11
Author: Victor Stinner 
Date:   Sat Dec 26 01:45:43 2020 +0100

bpo-42745: Make the type cache per-interpreter (GH-23947)

Make the type attribute lookup cache per-interpreter.

Add private _PyType_InitCache() function, called by 
PyInterpreterState_New().

Continue to share next_version_tag between interpreters, since static
types are still shared by interpreters.

Remove MCACHE macro: the cache is no longer disabled if the
EXPERIMENTAL_ISOLATED_SUBINTERPRETERS macro is defined.

 Include/internal/pycore_interp.h   |  22 +++
 Include/internal/pycore_object.h   |   3 +
 Include/internal/pycore_pylifecycle.h  |   2 +-
 .../2020-12-25-23-30-58.bpo-42745.XsFoHS.rst   |   1 +
 Objects/typeobject.c   | 178 -
 Python/pylifecycle.c   |   2 +-
 Python/pystate.c   |   2 +
 7 files changed, 128 insertions(+), 82 deletions(-)
 create mode 100644 Misc/NEWS.d/next/Core and 
Builtins/2020-12-25-23-30-58.bpo-42745.XsFoHS.rst
bisect run success

I assume PR 23953 fixes those? If that is so, could we land it before more 
buildbots start to fail?

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +22800
pull_request: https://github.com/python/cpython/pull/23953

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 41010184880151d6ae02a226dbacc796e5c90d11 by Victor Stinner in 
branch 'master':
bpo-42745: Make the type cache per-interpreter (GH-23947)
https://github.com/python/cpython/commit/41010184880151d6ae02a226dbacc796e5c90d11


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +22795
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23947

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[STINNER Victor]

Change by STINNER Victor :


--
title: [subinterpreters] Make the type lookup cache per-interpreter -> 
[subinterpreters] Make the type attribute lookup cache per-interpreter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com