[issue42847] Normalise file encodings in Lib/sqlite3/test/

[Berker Peksag]

Berker Peksag  added the comment:

iso-8859-1 is still commonly used in some parts of Nordic countries, but I 
don't see a reason not to change it here :) Thank you, Erlend!

--
components: +Tests -Library (Lib)
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42847] Normalise file encodings in Lib/sqlite3/test/

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42847] Normalise file encodings in Lib/sqlite3/test/

[Berker Peksag]

Berker Peksag  added the comment:


New changeset deab1e54ff1695cdbe87f8db3d2c382d8e78330f by Erlend Egeberg 
Aasland in branch 'master':
bpo-42847: Normalise Lib/sqlite3/test/* file encodings (GH-24147)
https://github.com/python/cpython/commit/deab1e54ff1695cdbe87f8db3d2c382d8e78330f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42847] Normalise file encodings in Lib/sqlite3/test/

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
keywords: +patch
pull_requests: +22975
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24147

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42847] Normalise file encodings in Lib/sqlite3/test/

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Indeed it is. I'll create a PR as soon as GH-20538 is merged.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42847] Normalise file encodings in Lib/sqlite3/test/

[Guido van Rossum]

Guido van Rossum  added the comment:

SGTM, the use of ISO-8859 is surely a legacy issue.

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42847] Normalise file encodings in Lib/sqlite3/test/

[Erlend Egeberg Aasland]

New submission from Erlend Egeberg Aasland :

GitHub does not play well with other file encodings than UTF-8. For example, 
when the "suggestion" in 
https://github.com/python/cpython/pull/20538#discussion_r552926126 was applied, 
GitHub silently converted Lib/sqlite3/test/types.py from ISO-8859 to UTF-8, as 
seen in the resulting commit fd4f65141925f2d84e0efd17ca4b9395c171d7ba. Apart 
from being annoying, this created an inconsistency between the `#-*- coding: 
iso-8859-1 -*-` header in Lib/sqlite3/test/types.py and its actual encoding 
(now UTF-8).

I suggest to convert Lib/sqlite3/test/* to UTF-8 encoding for consistency.

$ file Lib/sqlite3/test/*.py
Lib/sqlite3/test/backup.py:Python script text executable, ASCII text
Lib/sqlite3/test/dbapi.py: Python script text executable, ISO-8859 text
Lib/sqlite3/test/dump.py:  Python script text executable, ASCII text
Lib/sqlite3/test/factory.py:   Python script text executable, ISO-8859 text
Lib/sqlite3/test/hooks.py: Python script text executable, ISO-8859 text
Lib/sqlite3/test/regression.py:Python script text executable, ISO-8859 text
Lib/sqlite3/test/transactions.py:  Python script text executable, ISO-8859 text
Lib/sqlite3/test/types.py: Python script text executable, ISO-8859 text
Lib/sqlite3/test/userfunctions.py: Python script text executable, UTF-8 Unicode 
text

--
components: Library (Lib)
messages: 384543
nosy: berker.peksag, erlendaasland
priority: normal
severity: normal
status: open
title: Normalise file encodings in Lib/sqlite3/test/
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com