[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 5ec275758dbc307e9838e7038bfc3b5390950ea7 by Miss Islington (bot) 
in branch '3.10':
bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and 
_ssl._SSLSocket.write (GH-27271) (GH-27308)
https://github.com/python/cpython/commit/5ec275758dbc307e9838e7038bfc3b5390950ea7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 83d1430ee5b8008631e7f2a75447e740eed065c1 by Pablo Galindo Salgado 
in branch 'main':
bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and 
_ssl._SSLSocket.write (GH-27271)
https://github.com/python/cpython/commit/83d1430ee5b8008631e7f2a75447e740eed065c1


--
message_count: 11.0 -> 12.0
nosy: +miss-islington
nosy_count: 5.0 -> 6.0
pull_requests: +25853
pull_request: https://github.com/python/cpython/pull/27308

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +25815
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/27271

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

I will push a fix today

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Ned Deily]

Change by Ned Deily :


--
nosy: +pablogsal
stage: resolved -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Filipe Laíns]

Filipe Laíns  added the comment:

https://twitter.com/geofft/status/1417167982665551877

--
nosy: +FFY00
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Geoffrey Thomas]

Geoffrey Thomas  added the comment:

Christian mentioned on Twitter that this is probably due to a missing argument 
clinic change from "int" to "Py_ssize_t". I can confirm that fixing that and 
rerunning argument clinic makes things start to work.

I don't have the ability to reopen this bug (I think), can someone reopen it 
please?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Geoffrey Thomas]

Geoffrey Thomas  added the comment:

I am still seeing failures to read responses over 2 GB in Python 3.10b1. I'm 
working on a reproducer, but I'm getting the same "OverflowError: signed 
integer is greater than maximum" that I get in 3.9.

--
nosy: +geofft

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Ethan Furman]

Ethan Furman  added the comment:

False alarm, sorry.  Still getting used to merging, rebasing, etc.

Current tests run fine.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Ethan Furman]

Change by Ethan Furman :


--
Removed message: https://bugs.python.org/msg391419

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Christian Heimes]

Christian Heimes  added the comment:

Ethan, what's your platform and OpenSSL version?

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Ethan Furman]

Ethan Furman  added the comment:

I'm getting this error:

test test_ssl failed -- Traceback (most recent call last):
  File "/source/python/cpython/Lib/test/test_ssl.py", line 1061, in 
test_read_write_zero
self.assertEqual(s.send(b""), 0)
  File "/source/python/cpython/Lib/ssl.py", line 1198, in send
return self._sslobj.write(data)
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:2484)

Let me know if there's any other info I can provide (and how to get it).

--
nosy: +ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Christian Heimes]

Change by Christian Heimes :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 89d1550d14ba689af12eeb726e4ff8ce73cee7e1 by Christian Heimes in 
branch 'master':
bpo-42854: Use SSL_read/write_ex() (GH-25468)
https://github.com/python/cpython/commit/89d1550d14ba689af12eeb726e4ff8ce73cee7e1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Christian Heimes]

Christian Heimes  added the comment:

SSL_write_ex() and SSL_read_ex() solve two issues:

* bpo-42853: SSLSocket no longer raises overflow error when sending or 
receiving more than 2 GB of data
* bpo-31711: empty send(b"") no longer fails with protocol violation exception

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Christian Heimes]

Change by Christian Heimes :


--
keywords: +patch
pull_requests: +24193
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/25468

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Christian Heimes]

Christian Heimes  added the comment:

3.10 branch now requires OpenSSL 1.1.1. This should be easy to implement.

--
keywords: +easy (C)
priority: normal -> high
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Christian Heimes]

Christian Heimes  added the comment:

As of version 3.3.1, LibreSSL does not have SSL_write_ex() and SSL_read_ex(). 
The read and write functions are limited to int.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42854] OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[Christian Heimes]

New submission from Christian Heimes :

SSL_read() and SSL_write() are limited to int. The new SSL_write_ex() and 
SSL_read_ex() APIs support size_t just like read(2) and recv(2). Also see 
bpo-42853.

int SSL_write_ex(SSL *s, const void *buf, size_t num, size_t *written);
int SSL_read_ex(SSL *ssl, void *buf, size_t num, size_t *readbytes);

Both functions return 1 for success or 0 for failure.

--
assignee: christian.heimes
components: SSL
messages: 384567
nosy: christian.heimes
priority: normal
severity: normal
status: open
title: OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()
type: enhancement
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com