[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 40901518167c66abc1ebc5b71c5b86d733cfa154 by Pablo Galindo in 
branch 'master':
bpo-42986: Fix parser crash when reporting syntax errors in f-string with 
newlines (GH-24279)
https://github.com/python/cpython/commit/40901518167c66abc1ebc5b71c5b86d733cfa154


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[neonene]

neonene  added the comment:

For me, I confirmed no crash with PR 24279.
Thanks for the fix in no time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +23102
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24279

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Seems that this problem was introduced by 
e5fe509054183bed9aef42c92da8407d339e8af8

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[neonene]

New submission from neonene :

On Windows, Python master crashes using f-string (which has an invalid char 
with braces) on line 3 and after.
It seems the issue is from commit (e5fe509054183bed9aef42c92da8407d339e8af8).

I tried

1) exec("f'{.}'")
2) exec("\nf'{.}'")
3) exec("\n\nf'{.}'")

commands and results are

1) expected
>>> exec("f'{.}'")
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 1
(.)
 ^
SyntaxError: f-string: invalid syntax

2) unexpected (caret indicates nothing)
>>> exec("\nf'{.}'")
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 2

^
SyntaxError: f-string: invalid syntax

3) python crashes
>>> exec("\n\nf'{.}'")

--
components: Interpreter Core
messages: 385377
nosy: lys.nikolaou, neonene, pablogsal
priority: normal
severity: normal
status: open
title: pegen parser: Crash on SyntaxError with f-string on Windows
type: crash
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com