[issue43235] Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows stable ABI)

[Petr Viktorin]

Petr Viktorin  added the comment:

Since PEP 652, PC/python3dll.c is generated from the stable ABI definition.
Checking (i.e. running the tool without --generate) ensures it is up-to-date.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43235] Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows stable ABI)

[hai shi]

hai shi  added the comment:

> It would be great to have a tool to check that all symbols exported on Unix 
> are also exported on Windows.

I write a demo in PR 24639(compare the stable_abi.dat to python3dll.c).
And the output result:
```
Some symbols from the limited API on windows are missing:
PyMarshal_WriteObjectToFile, PyThread_allocate_lock, PyObject_GC_IsFinalized, 
PyThread_ReInitTLS, PyThread_acquire_lock, PyThread_GetInfo, 
PyDictRevIterValue_Type, PyThread_get_thread_native_id, 
PyThread_start_new_thread, PyThread_set_stacksize, PyDictRevIterKey_Type, 
PyOS_AfterFork_Child, PyThread_create_key, PyThread_get_thread_ident, 
PyOS_BeforeFork, Py_BytesMain, PyThread_get_key_value, PyCodec_Unregister, 
PyInterpreterState_Get, PyMember_GetOne, PyThread_init_thread, 
PyInterpreterState_GetDict, PyThread_set_key_value, PyThread_delete_key, 
PyMarshal_WriteObjectToString, PyOS_AfterFork_Parent, 
PyThread_delete_key_value, PyObject_GC_IsTracked, 
PyMarshal_ReadObjectFromString, PyMarshal_WriteLongToFile, 
PyThread_exit_thread, PyThread_acquire_lock_timed, PyThread_get_stacksize, 
PyMember_SetOne, PyDictRevIterItem_Type, PyThread_free_lock, 
PyThread_release_lock

This error normally means that there are some missing symbols on windows.

Check if this was a mistake and if not, update the file containing the limited
API symbols. This file is located at:

PC/python3dll.c

You can read more about the limited API and its contracts at:

https://docs.python.org/3/c-api/stable.html

And in PEP 384:

https://www.python.org/dev/peps/pep-0384/

```

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43235] Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows stable ABI)

[hai shi]

Change by hai shi :


--
keywords: +patch
nosy: +shihai1991
nosy_count: 4.0 -> 5.0
pull_requests: +23424
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24639

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43235] Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows stable ABI)

[Petr Viktorin]

Petr Viktorin  added the comment:

I want to address this in PEP 652.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43235] Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows stable ABI)

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43235] Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows stable ABI)

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +pablogsal, petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43235] Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows stable ABI)

[STINNER Victor]

New submission from STINNER Victor :

bpo-43155 is just yet another example that we always forget to export symbols 
of the stable ABI on Windows.

It would be great to have a tool to check that all symbols exported on Unix are 
also exported on Windows.

Tools/scripts/stable_abi.py could check PC/python3dll.c (Windows stable ABI). 
For example, currently "PyCMethod_New" symbol is in Doc/data/stable_abi.dat but 
miss in PC/python3dll.c.

--
components: C API
messages: 387073
nosy: vstinner
priority: normal
severity: normal
status: open
title: Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows 
stable ABI)
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com