[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

I marked bpo-35197 as a duplicate of this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

"Remove Yield macro from pycore_ast.h"

I'm happy that this one is gone, it was a common and annoying compiler warning 
on Windows!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset d27f8d2e07d31670af469ef387a37bc9e96ea8ad by Victor Stinner in 
branch 'master':
bpo-43244: Rename pycore_ast.h functions to _PyAST_xxx() (GH-25252)
https://github.com/python/cpython/commit/d27f8d2e07d31670af469ef387a37bc9e96ea8ad


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

typed-ast was updated for these changes and to avoid including explicitly 
pydebug.h (it's included by Python.h: see bpo-35134 change): 
https://github.com/python/typed_ast/pull/158

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23992
pull_request: https://github.com/python/cpython/pull/25256

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23990
pull_request: https://github.com/python/cpython/pull/25252

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset d36d6a9c1808e87628ebaa855d4bec80130189f4 by Victor Stinner in 
branch 'master':
bpo-43244: Remove Yield macro from pycore_ast.h (GH-25243)
https://github.com/python/cpython/commit/d36d6a9c1808e87628ebaa855d4bec80130189f4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23983
pull_request: https://github.com/python/cpython/pull/25243

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23982
pull_request: https://github.com/python/cpython/pull/25242

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

In short, this issue is a follow-up of bpo-40939.

These C API removal are related to the final step of the PEP 617 "New PEG 
parser for CPython": removal of the PyParser C API.

* The PyParser C API produced "node*" objects, like 
PyParser_SimpleParseFile(FILE*) => node*. This C API was removed in Python 
3.10: bpo-40939 "Remove the old parser".

* The AST C API takes "node*" as input: PyAST_FromNode(node*) => mod_ty. I 
removed these APIs.

* symtable takes "mod_ty" as input.

* ASDL and PyArena API were only useful for the removed AST C APIs.

I searched for removed functions in the top PyPI 4000 projects, there is a 
single project on 4000: typed_ast. This typed_ast project is special, it copies 
directly code from CPython. Even after the C API removed, typed_ast can 
continue to use the internal C API, it only has to define the 
Py_BUILD_CORE_MODULE macro.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

Ok, the whole C API related to parser, compiler, AST, ASDL and PyArena moved to 
the internal C API. So we will have more freedom to evolve it!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 8370e07e1e5b626e78ddc7aadbfaf248976c4454 by Victor Stinner in 
branch 'master':
bpo-43244: Remove the pyarena.h header (GH-25007)
https://github.com/python/cpython/commit/8370e07e1e5b626e78ddc7aadbfaf248976c4454


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23765
pull_request: https://github.com/python/cpython/pull/25007

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 57364ce34e0492fbc8b0a6b8c882f384bb489457 by Victor Stinner in 
branch 'master':
bpo-43244: Remove parser_interface.h header file (GH-25001)
https://github.com/python/cpython/commit/57364ce34e0492fbc8b0a6b8c882f384bb489457


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset a81fca6ec8e0f748f8eafa12fb12cf9e12df465c by Victor Stinner in 
branch 'master':
bpo-43244: Add pycore_compile.h header file (GH-25000)
https://github.com/python/cpython/commit/a81fca6ec8e0f748f8eafa12fb12cf9e12df465c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23759
pull_request: https://github.com/python/cpython/pull/25001

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23758
pull_request: https://github.com/python/cpython/pull/25000

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 94faa0724f8cbae6867c491c8e465e35f4fdbfbb by Victor Stinner in 
branch 'master':
bpo-43244: Remove ast.h, asdl.h, Python-ast.h headers (GH-24933)
https://github.com/python/cpython/commit/94faa0724f8cbae6867c491c8e465e35f4fdbfbb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23694
pull_request: https://github.com/python/cpython/pull/24933

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 28ad12f8fe889a741661eb99daacebd9243cc1ba by Victor Stinner in 
branch 'master':
bpo-43244: Remove symtable.h header file (GH-24910)
https://github.com/python/cpython/commit/28ad12f8fe889a741661eb99daacebd9243cc1ba


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

The work on this issue started in Python 3.9 with bpo-21120 which excluded 
Python-ast.h, ast.h and asdl.h from the limited C API: commit 
421a72af4deaec96a49a79951b9c2546a2faa13d.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset eec8e61992fb654d4cf58de4d727c18622b8303e by Victor Stinner in 
branch 'master':
bpo-43244: Remove the PyAST_Validate() function (GH-24911)
https://github.com/python/cpython/commit/eec8e61992fb654d4cf58de4d727c18622b8303e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 6af528b4ab342805534c0bfe61d84ed7bb519468 by Victor Stinner in 
branch 'master':
bpo-43244: Fix test_peg_generators on Windows (GH-24913)
https://github.com/python/cpython/commit/6af528b4ab342805534c0bfe61d84ed7bb519468


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23677
pull_request: https://github.com/python/cpython/pull/24914

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23676
pull_request: https://github.com/python/cpython/pull/24913

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset e0bf70d08c4a4a68782702e747e6bf7670667591 by Victor Stinner in 
branch 'master':
bpo-43244: Fix test_peg_generator for PyAST_Validate() (GH-24912)
https://github.com/python/cpython/commit/e0bf70d08c4a4a68782702e747e6bf7670667591


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23675
pull_request: https://github.com/python/cpython/pull/24912

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23673
pull_request: https://github.com/python/cpython/pull/24911

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23672
pull_request: https://github.com/python/cpython/pull/24910

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 526fdeb2278b61653df704d7cfcaedde504dee48 by Victor Stinner in 
branch 'master':
bpo-43244: Add pycore_ast.h header file (GH-24908)
https://github.com/python/cpython/commit/526fdeb2278b61653df704d7cfcaedde504dee48


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23670
pull_request: https://github.com/python/cpython/pull/24908

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset b4536e1c6abe4c6219177a89e16575d05ea22f64 by Victor Stinner in 
branch 'master':
bpo-43244: Rename pycore_ast.h to pycore_ast_state.h (GH-24907)
https://github.com/python/cpython/commit/b4536e1c6abe4c6219177a89e16575d05ea22f64


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +23669
pull_request: https://github.com/python/cpython/pull/24907

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[hai shi]

Change by hai shi :


--
keywords: +patch
nosy: +shihai1991
nosy_count: 1.0 -> 2.0
pull_requests: +23470
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24688

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43244] Move PyArena C API to the internal C API

[STINNER Victor]

New submission from STINNER Victor :

Include/cpython/pyarena.h declares 4 functions which are implemented in 
Python/pyarena.c. The header file exists to access these functions from the 
compiler. IMO there was no intent to expose these functions to the public 
Python C API.

Moreover, the PEP 384 explicitly excludes this API from the stable ABI (from 
the limited C API).

I propose to move these functions to the internal C API.

Since these functions are no even documented, I don't think that a deprecation 
period is needed.

Note: The PR 24550 moved Include/pyarena.h to Include/cpython/pyarena.h.

--
components: C API
messages: 387180
nosy: vstinner
priority: normal
severity: normal
status: open
title: Move PyArena C API to the internal C API
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com