[issue43265] [sqlite3] Improve backup error handling

[Berker Peksag]

Berker Peksag  added the comment:

Thank you.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43265] [sqlite3] Improve backup error handling

[Berker Peksag]

Berker Peksag  added the comment:


New changeset c1ae7419975f7d664320f66ea3acc8663bbf76cf by Erlend Egeberg 
Aasland in branch 'master':
bpo-43265: Improve sqlite3.Connection.backup error handling (GH-24586)
https://github.com/python/cpython/commit/c1ae7419975f7d664320f66ea3acc8663bbf76cf


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43265] [sqlite3] Improve backup error handling

[Berker Peksag]

Change by Berker Peksag :


Removed file: https://bugs.python.org/file49823/DOC-20200420-WA

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43265] [sqlite3] Improve backup error handling

[Berker Peksag]

Berker Peksag  added the comment:

> 3.9, I presume?

Yes, I was going too fast :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43265] [sqlite3] Improve backup error handling

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Regarding 1: After thinking about it, I see nothing wrong with raising 
ValueError error. No need to change current behaviour.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43265] [sqlite3] Improve backup error handling

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

3.9, I presume? Yeah, I guess so.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43265] [sqlite3] Improve backup error handling

[Berker Peksag]

Berker Peksag  added the comment:

I'd even consider a cryptic error message a minor usability bug and backport it 
to at least 3.10.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43265] [sqlite3] Improve backup error handling

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

The unit test suite shows one case of improved "exception text". I'd say it's 
an improvement.

$ ./python.exe  # with GH-24586 applied
>>> import sqlite3
>>> c1 = sqlite3.connect(":memory:")
>>> c2 = sqlite3.connect(":memory:")
>>> c1.backup(c2, name="non-existing")
Traceback (most recent call last):
  File "", line 1, in 
sqlite3.OperationalError: unknown database non-existing

$ python3.10  # latest alpha from python.org
>>> import sqlite3
>>> c1 = sqlite3.connect(":memory:")
>>> c2 = sqlite3.connect(":memory:")
>>> c1.backup(c2, name="non-existing")
Traceback (most recent call last):
  File "", line 1, in 
sqlite3.OperationalError: SQL logic error

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43265] [sqlite3] Improve backup error handling

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
title: Improve sqlite3 backup error handling -> [sqlite3] Improve backup error 
handling

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com