[issue43359] Dead assignment in Py_UniversalNewlineFgets

[Irit Katriel]

Irit Katriel  added the comment:

That function has been edited in the meantime and this line is no longer there.

--
nosy: +iritkatriel
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43359] Dead assignment in Py_UniversalNewlineFgets

[STINNER Victor]

STINNER Victor  added the comment:

> Hi Victor, just so we're all on the same page, removing the line does not 
> trigger a compiler warning. The comment on this line is misleading.

I wrote the opposite. IMO the line and its commment should be kept.

> Defect identified by scan-build 
> 

Just tell your tool that the line is there on purpose.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43359] Dead assignment in Py_UniversalNewlineFgets

[Alex Henrie]

Alex Henrie  added the comment:

Hi Victor, just so we're all on the same page, removing the line does not 
trigger a compiler warning. The comment on this line is misleading.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43359] Dead assignment in Py_UniversalNewlineFgets

[STINNER Victor]

STINNER Victor  added the comment:

> c = 'x'; /* Shut up gcc warning */

IMHO this code is fine and should be kept. I hate fighting against stupid false 
alarms of compiler warnings. This code is harmless. It doesn't affect 
performances or anything.

I suggest to close this issue and its PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43359] Dead assignment in Py_UniversalNewlineFgets

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Victor and/or Serhiy: This and #43360 and #43361 are similar 1-line changes, 
suggested by scan-build, to eliminate dead or duplicate initializations in C 
code.  Can either of you either handle these or suggest someone else?  Would we 
have preferred 1 issue and PR?  Do we backport such changes?

All 3 diffs have a bunch of github beta check annotation warnings for an 
otherwise unchanged C file.  Fix?  Suppress somehow?

--
nosy: +serhiy.storchaka, terry.reedy, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com