[issue43422] Revert _decimal C API changes

[Antoine Pitrou]

Change by Antoine Pitrou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[miss-islington]

miss-islington  added the comment:


New changeset cdddc2b742750e3f289305cf276433a8170c32c1 by Antoine Pitrou in 
branch 'master':
bpo-43422: Revert _decimal C API addition (GH-24960)
https://github.com/python/cpython/commit/cdddc2b742750e3f289305cf276433a8170c32c1


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Antoine Pitrou]

Change by Antoine Pitrou :


--
pull_requests: +23718
pull_request: https://github.com/python/cpython/pull/24960

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Antoine Pitrou]

Antoine Pitrou  added the comment:

FWIW, I have the roles "User,Developer,Coordinator" according to my user page.
You (Terry) have the roles "User,Developer".
Perhaps the "Coordinator" role explains I see things you don't see (it's a 
better explanation than believing I am a psychic :-D).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Terry J. Reedy]

Terry J. Reedy  added the comment:

OK.  I see no structural difference between his page and yours, 
https://bugs.python.org/user2040.  No 'Roles' field, no 'User' entry, on either 
page, nor on mine.  So you must be an admin who sees extra info.  In any case, 
the last part of my comment stands.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Terry, the list of roles in https://bugs.python.org/user11089 is empty, which I 
take it to mean that Stefan doesn't have any access rights on this issue 
tracker (except to read issues).  Other users all seem to have the "User" role.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Terry J. Reedy]

Terry J. Reedy  added the comment:

skrah is still a bpo user with an CLA-signed account linked to his github 
account.  So he can post here and, I believe, open a PR as a contributor.  But 
if, under the current circumstances, he feels more comfortable using Antoine as 
a go between, then I thank Antoine for doing so.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Antoine Pitrou]

Change by Antoine Pitrou :


--
keywords: +patch
pull_requests: +23559
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24792

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[STINNER Victor]

STINNER Victor  added the comment:

I have a concern about the current _decimal C API: bpo-43060. I'm fine with 
removing it in Python 3.10, and add it back fixed in Python 3.11 or later.

> I can turn it into a PR but first I'd like to gather reactions here.

Go ahead.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[hai shi]

hai shi  added the comment:

+1 from me. 3.10.0 final haven't been released, so no one will be affected.

--
nosy: +shihai1991, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Mark Dickinson]

Mark Dickinson  added the comment:

+1 for reverting these before 3.10. See also @mattip's comments on #41324, and 
#43060.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Raymond Hettinger]

Raymond Hettinger  added the comment:

+1 fron me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43422] Revert _decimal C API changes

[Antoine Pitrou]

New submission from Antoine Pitrou :

Stefan Krah (who doesn't have access rights here, and is the author of the C 
_decimal module) asked me to transmit me this request:
"""
The capsule API does not meet my testing standards, since I've focused
on the upstream mpdecimal in the last couple of months.

Additionally, I'd like to refine the API, perhaps together with the
Arrow community.
"""

The relevant diff is here:
https://github.com/python/cpython/compare/master...skrah:revert_decimal_capsule_api

I can turn it into a PR but first I'd like to gather reactions here.

--
components: Extension Modules
messages: 388205
nosy: facundobatista, mark.dickinson, pitrou, rhettinger, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Revert _decimal C API changes
type: behavior
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com