[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[STINNER Victor]

STINNER Victor  added the comment:

It seems like the issue is now fixed. Thanks Serhiy for the fix and thanks 
OndrejPtak for the report!

> This change will go into a future 3.9 release?

Yes, sure. Python 3.9 Release Schedule:
https://www.python.org/dev/peps/pep-0596/

Next expected release: Python 3.9.3: Monday, 2021-05-03.

--
nosy: +vstinner
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[frathgeber]

frathgeber  added the comment:

Thanks Serhiy for the very quick fix! I believe handling these corner cases is 
not worth the effort and I really hope no one relies on these being 
differentiated. This change will go into a future 3.9 release?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[miss-islington]

miss-islington  added the comment:


New changeset 5334605035d38139a04189ecb3899f36702517b2 by Miss Islington (bot) 
in branch '3.9':
bpo-43433: Preserve query and fragment in the URL of the server in ServerProxy. 
(GH-25057)
https://github.com/python/cpython/commit/5334605035d38139a04189ecb3899f36702517b2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[Dong-hee Na]

Dong-hee Na  added the comment:


New changeset c1b073a630bb731de18bb17afb2b8b1388b92a72 by Serhiy Storchaka in 
branch 'master':
bpo-43433: Preserve query and fragment in the URL of the server in ServerProxy. 
(GH-25057)
https://github.com/python/cpython/commit/c1b073a630bb731de18bb17afb2b8b1388b92a72


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 7.0 -> 8.0
pull_requests: +23818
pull_request: https://github.com/python/cpython/pull/25068

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you for your reports OndrejPtak and frathgeber.

Indeed, the behavior change was unintended. PR 25057 tries to to restore the 
old behavior. Query and fragment are now preserved in the server URL.

But there are still minor differences. Empty query and fragment are stripped 
from the URL, so "http://example.org/RPC2?;, "http://example.org/RPC2#; and 
"http://example.org/RPC2; refer to the same connection point. I am not sure 
that it is important. It would be not easy to preserve the old behavior in 
these corner cases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +23804
pull_request: https://github.com/python/cpython/pull/25057

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[frathgeber]

Change by frathgeber :


--
nosy: +kynan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[Chris Angelico]

Chris Angelico  added the comment:

Can confirm. This changed in bpo-38038 and the fix isn't too difficult.

Adding 3.10 in case it's decided that this shouldn't be patched onto 3.9.

--
versions: +Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[Chris Angelico]

Change by Chris Angelico :


--
keywords: +patch
nosy: +Rosuav
nosy_count: 3.0 -> 4.0
pull_requests: +23793
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/25045

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[OndrejPtak]

OndrejPtak  added the comment:

Reproducer:
* create ServerProxy with UPI containing query part, e.g. 
http://example.com?foo=bar
* communicate

Old behavior:
-
send: b'POST /?foo=bar HTTP/1.1\r\nHost: example.com\r\nAccept-Encoding: 
gzip\r\nContent-Type: text/xml\r\nUser-Agent: 
Python-xmlrpc/3.8\r\nContent-Length: 197\r\n\r\n'
send: b"\n\ngetRecentChanges\n\n\n20210301T00:00:00\n\n\n\n"

New behaviour:
--
send: b'POST / HTTP/1.1\r\nHost: example.com\r\nAccept-Encoding: 
gzip\r\nContent-Type: text/xml\r\nUser-Agent: 
Python-xmlrpc/3.9\r\nContent-Length: 197\r\n\r\n'
send: b"\n\ngetRecentChanges\n\n\n20210301T00:00:00\n\n\n\n"

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[Tomas Orsava]

Change by Tomas Orsava :


--
nosy: +eli.bendersky, scoder

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[Tomas Orsava]

Change by Tomas Orsava :


--
components: +XML

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43433] xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

[OndrejPtak]

Change by OndrejPtak :


--
title: xmlrpc.client ignores query in URI ("?action=xmlrpc2") from python-3.9 
-> xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com