[issue43731] PEP 597: logging.fileConfig() uses locale encoding.

[Inada Naoki]

Inada Naoki  added the comment:

> Ah, so you want to emit an EncodingWarning when fileConfig(filename) is 
> called without specifying an encoding, right?

Yes, but only when the user uses `PYTHONWARNDEFAULTENCODING`.

I already added `export PYTHONWARNDEFAULTENCODING=1` in `.bashrc` in my mac and 
Linux machine.

In the future, config file should be read with UTF-8 by default.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43731] PEP 597: logging.fileConfig() uses locale encoding.

[STINNER Victor]

STINNER Victor  added the comment:

Ah, so you want to emit an EncodingWarning when fileConfig(filename) is called 
without specifying an encoding, right?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43731] PEP 597: logging.fileConfig() uses locale encoding.

[Inada Naoki]

Inada Naoki  added the comment:

If we use `encoding="locale"` by default, EncodingWarning will be not be 
emitted  even when user omit `encoding` option.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43731] PEP 597: logging.fileConfig() uses locale encoding.

[STINNER Victor]

STINNER Victor  added the comment:

> fileConfig(fname, defaults=None, disable_existing_loggers=True, encoding=None)

If "locale" is the intended default, why not being more explicit and use 
encoding="locale"?

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43731] PEP 597: logging.fileConfig() uses locale encoding.

[Inada Naoki]

Inada Naoki  added the comment:


New changeset c2b7a66b91cdb96fbfdb160f96797208ddc5e436 by Inada Naoki in branch 
'master':
bpo-43731: Add an `encoding` parameter to logging.fileConfig() (GH-25273)
https://github.com/python/cpython/commit/c2b7a66b91cdb96fbfdb160f96797208ddc5e436


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43731] PEP 597: logging.fileConfig() uses locale encoding.

[Inada Naoki]

Change by Inada Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43731] PEP 597: logging.fileConfig() uses locale encoding.

[Inada Naoki]

Change by Inada Naoki :


--
keywords: +patch
pull_requests: +24009
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/25273

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43731] PEP 597: logging.fileConfig() uses locale encoding.

[Inada Naoki]

Inada Naoki  added the comment:

s/basicConfig/fileConfig/

basicConfig() is fixed by fb7869.

--
title: PEP 597: logging.basicConfig() uses locale encoding. -> PEP 597: 
logging.fileConfig() uses locale encoding.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com