[issue43894] IDLE editor file minor refactoring

[E. Paine]

E. Paine  added the comment:

I agree with your points and understand that there is good reason for the PR to 
be rejected. If Terry decides it's too big (I did do a lot more than what was 
originally in PR-22682), I am more than happy to close this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43894] IDLE editor file minor refactoring

[Terry J. Reedy]

Terry J. Reedy  added the comment:

This started as an extraction and revision of changes in Tal's PR, one of which 
appeared to be an intended behavior change, that I requested there.  Paine may 
have expanded the scope more than I intended.  Will look soon.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43894] IDLE editor file minor refactoring

[Éric Araujo]

Éric Araujo  added the comment:

Hello and thanks for wanting to contribute to Python!

In the CPython project, stylistic changes are not made by themselves as a 
matter of course (accross the whole codebase or in a specific module): among 
reasons, these obfuscate file history, need reviewer time that takes away from 
other changes, and can introduce subtle bugs.  Or in short: if it’s not broken, 
don’t fix it!

This is different from other projects, especially those that have a smaller 
codebase, much less history than Python, and can agree on using some automated 
tool for trivial formatting changes.

So if the changes here are not motivated by a bugfix or a new features, I think 
they should not be accepted.

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43894] IDLE editor file minor refactoring

[E. Paine]

Change by E. Paine :


--
keywords: +patch
pull_requests: +24211
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/25485

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43894] IDLE editor file minor refactoring

[E. Paine]

New submission from E. Paine :

Despite being large, the PR is mostly trivial changes (e.g. changing 
indentation). The main changes worth noting (and hence the reason for this 
issue) are:
1) the renaming of `ResetColorizer` to `reset_colors`, `ResetFont` to 
`reset_font`, `RemoveKeybindings` to `remove_keybindings` and 
`ApplyKeybindings` to `apply_keybindings`.
2) removal of some potentially unneeded imports
3) renaming of the `tokeneater` args to be lowercase

I chose `reset_colors` (as proposed in PR-22682) rather than `reset_colorizer` 
because we are reconfiguring the Text, code context and line numbers, rather 
than only dealing with the colouriser.

--
assignee: terry.reedy
components: IDLE
messages: 391449
nosy: epaine, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE editor file minor refactoring
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com