[issue44063] compiler: does not revert back the end_* locations

[Batuhan Taskaya]

Change by Batuhan Taskaya :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44063] compiler: does not revert back the end_* locations

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:


New changeset 13de28f17af02563cb8c6d0f6da3c178a4241ff3 by Miss Islington (bot) 
in branch '3.10':
bpo-44063: set the missing end locations on the compiler (GH-25956) (#25972)
https://github.com/python/cpython/commit/13de28f17af02563cb8c6d0f6da3c178a4241ff3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44063] compiler: does not revert back the end_* locations

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 1.0 -> 2.0
pull_requests: +24628
pull_request: https://github.com/python/cpython/pull/25972

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44063] compiler: does not revert back the end_* locations

[Batuhan Taskaya]

Change by Batuhan Taskaya :


--
keywords: +patch
pull_requests: +24617
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/25956

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44063] compiler: does not revert back the end_* locations

[Batuhan Taskaya]

New submission from Batuhan Taskaya :

Something that I've stumbled up while working on another patch is that, the 
compiler doesn't revert the end_lineno and the end_col_offset attributes back 
unlike regular lineno/col_offset. An example of this problem;
ar rcs libpython3.10d.a Modules/getbuildinfo.o Parser/token.o  Parser/pegen.o 
Parser/parser.o Parser/string_parser.o Parser/peg_api.(.venv38) (Python 3.8.5+) 
[ 10:33ÖS ]  [ isidentical@desktop:~/cpython/cpython(main✔) ]
 $ cat t3.py 
def foo(a):
pass

foo(
a=1,
a=2
)

 $ ./python t3.py
  File "/home/isidentical/cpython/cpython/t3.py", line 4
foo(
^
SyntaxError: keyword argument repeated: a

with the fix

 $ ./python t3.py
  File "/home/isidentical/cpython/cpython/t3.py", line 6
a=2
^^^
SyntaxError: keyword argument repeated: a

--
messages: 393138
nosy: BTaskaya
priority: normal
severity: normal
status: open
title: compiler: does not revert back the end_* locations

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com