[issue44364] Add non integral tests for `sqrt()`

[Mark Dickinson]

Mark Dickinson  added the comment:

> 2921 is the smallest integers for which math.sqrt(x) > x**0.5

This is platform-dependent. On my machine, for example, `math.sqrt(2921) == 
2921**0.5` returns `True`.

I don't see a lot of value in additional tests here; we're only wrapping the 
libm sqrt, so we only really need enough testing to catch possible 
implementation errors in that wrapping. But testing only integers with an exact 
square root doesn't seem enough.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44364] Add non integral tests for `sqrt()`

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

65733 and 262694 are integers in range 1..100 with largest relative errors 
of naive square root (with different signs).

33031 and 524557 are integers in range 1..100 with largest relative errors 
of naive cube root (with different signs).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44364] Add non integral tests for `sqrt()`

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

>>> math.sqrt(2.5) == 2.5**0.5
True
>>> math.sqrt(25.25) == 25.25**0.5
True

If we test the precision of math.sqrt(), would not be better to test it with 
data for which naive way of calculating the root returns different result? For 
example 2921 is the smallest integers for which math.sqrt(x) > x**0.5, and 3541 
is the smallest integers for which math.sqrt(x) < x**0.5.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44364] Add non integral tests for `sqrt()`

[Mark Dickinson]

Change by Mark Dickinson :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44364] Add non integral tests for `sqrt()`

[Mark Dickinson]

New submission from Mark Dickinson :


New changeset 90cd4330329a99e52f7141db5e0a469d30088e66 by Ajith Ramachandran in 
branch 'main':
bpo-44364:Add non integral tests for `sqrt()` (#26625)
https://github.com/python/cpython/commit/90cd4330329a99e52f7141db5e0a469d30088e66


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44364] Add non integral tests for `sqrt()`

[Mark Dickinson]

Change by Mark Dickinson :


--
nosy: +mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44364] Add non integral tests for `sqrt()`

[Ajith Ramachandran]

Change by Ajith Ramachandran :


--
keywords: +patch
pull_requests: +25210
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26625

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44364] Add non integral tests for `sqrt()`

[Ajith Ramachandran]

Change by Ajith Ramachandran :


--
components: Tests
nosy: AjithRamachandran
priority: normal
severity: normal
status: open
title: Add non integral tests for `sqrt()`
type: enhancement
versions: Python 3.10, Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com