[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[miss-islington]

miss-islington  added the comment:


New changeset 08f2b9dedea13d2e9d11c189914387db3a66e2ca by Miss Islington (bot) 
in branch '3.10':
bpo-44389: Fix typo in ssl deprecation warning message (GH-26754)
https://github.com/python/cpython/commit/08f2b9dedea13d2e9d11c189914387db3a66e2ca


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[miss-islington]

Change by miss-islington :


--
pull_requests: +25351
pull_request: https://github.com/python/cpython/pull/26765

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[miss-islington]

miss-islington  added the comment:


New changeset c544393b89f9b3e2b1a22588fc9ae58019314879 by Joe in branch 'main':
bpo-44389: Fix typo in ssl deprecation warning message (GH-26754)
https://github.com/python/cpython/commit/c544393b89f9b3e2b1a22588fc9ae58019314879


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Josh Jiang]

Change by Josh Jiang :


--
nosy: +johnj
nosy_count: 5.0 -> 6.0
pull_requests: +25339
pull_request: https://github.com/python/cpython/pull/26754

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Thanks, Christian.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Christian Heimes]

Change by Christian Heimes :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[miss-islington]

miss-islington  added the comment:


New changeset 4becc569a606102bce624a4e28f4068317d09f42 by Miss Islington (bot) 
in branch '3.10':
[3.10] bpo-44389: Fix deprecation of OP_NO_TLSv1_3 (GH-26700) (GH-26705)
https://github.com/python/cpython/commit/4becc569a606102bce624a4e28f4068317d09f42


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Christian Heimes]

Christian Heimes  added the comment:

OpenSSL has deprecated these constants:

> SSL_OP_NO_SSLv3, SSL_OP_NO_TLSv1, SSL_OP_NO_TLSv1_1, SSL_OP_NO_TLSv1_2, 
> SSL_OP_NO_TLSv1_3, SSL_OP_NO_DTLSv1, SSL_OP_NO_DTLSv1_2
>
> As of OpenSSL 1.1.0, these options are deprecated, use 
> SSL_CTX_set_min_proto_version(3) and SSL_CTX_set_max_proto_version(3) instead.

https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_options.html

--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Christian Heimes]

Christian Heimes  added the comment:


New changeset bf527277d4e4907e32d76ca7ba667ab3149fe258 by Christian Heimes in 
branch 'main':
bpo-44389: Fix deprecation of OP_NO_TLSv1_3 (GH-26700)
https://github.com/python/cpython/commit/bf527277d4e4907e32d76ca7ba667ab3149fe258


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[miss-islington]

Change by miss-islington :


--
pull_requests: +25290
pull_request: https://github.com/python/cpython/pull/26705

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[miss-islington]

miss-islington  added the comment:


New changeset f30f484e9660c6ad5d5a554869593d14d709a7f4 by Miss Islington (bot) 
in branch '3.10':
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (GH-26680)
https://github.com/python/cpython/commit/f30f484e9660c6ad5d5a554869593d14d709a7f4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +25289
pull_request: https://github.com/python/cpython/pull/26704

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +25285
pull_request: https://github.com/python/cpython/pull/26700

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +25284
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/26699

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Ah, I see now that it's deprecated in the docs as well: 
https://docs.python.org/3/library/ssl.html#ssl.OP_NO_TLSv1_3

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Let me know if you want me to open a PR that adds the correct flag and adds 
deprecation wrappers to the tests.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Yes, and judging from PEP 644, I figured the TLSv1.3 flag was _not_ deprecated. 
Sorry for the misunderstanding/noise.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Christian Heimes]

Christian Heimes  added the comment:

3.10 requires OpenSSL >= 1.1.1

The code checks for presence of deprecated options and emits a warning for all 
SSL_OP_NO_TLS/SSL* constants.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Christian Heimes]

Change by Christian Heimes :


--
resolution: duplicate -> 
versions: +Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

But TLSv1.3 is included in openssl 1.1.1, no?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Christian Heimes]

Christian Heimes  added the comment:

It's a typo, not a duplicate entry. Correct line is:

SSL_OP_NO_TLSv1_1 | SSL_OP_NO_TLSv1_2 | SSL_OP_NO_TLSv1_3

--
nosy: +christian.heimes
resolution: fixed -> duplicate
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Thanks for the report, Brother Beer.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:


New changeset cb7230c7a7d6d497e54c25e9ba640eec79de10f2 by Erlend Egeberg 
Aasland in branch 'main':
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (GH-26680)
https://github.com/python/cpython/commit/cb7230c7a7d6d497e54c25e9ba640eec79de10f2


--
nosy: +nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
keywords: +patch
nosy: +erlendaasland
nosy_count: 1.0 -> 2.0
pull_requests: +25266
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26680

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

[Brother Beer]

New submission from Brother Beer :

cpython-3.10.0b2/Modules/_ssl.c  line 3576

3570 static int
3571 set_options(PySSLContext *self, PyObject *arg, void *c)
3572 {
3573 long new_opts, opts, set, clear;
3574 long opt_no = (
3575 SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_TLSv1 |
3576 SSL_OP_NO_TLSv1_1 | SSL_OP_NO_TLSv1_2 | SSL_OP_NO_TLSv1_2
3577 );

'SSL_OP_NO_TLSv1_2' is repeated, are any other items missing?

--
files: _ssl_c_line_3576.png
messages: 395612
nosy: brotherbeer
priority: normal
severity: normal
status: open
title: Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'
type: behavior
versions: Python 3.10
Added file: https://bugs.python.org/file50103/_ssl_c_line_3576.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com