[issue44439] stdlib wrongly uses len() for bytes-like object

[Ma Lin]

Ma Lin  added the comment:

`_Stream.write` method in tarfile.py also has this code:
https://github.com/python/cpython/blob/v3.11.0a6/Lib/tarfile.py#L434

But this bug will not be triggered. When calling this method, always pass bytes 
data.

`_ConnectionBase.send_bytes` method in multiprocessing\connection.py can be 
micro-optimized:
https://github.com/python/cpython/blob/v3.11.0a6/Lib/multiprocessing/connection.py#L193
This can be done in another issue.

So I think this issue can be closed.

--
stage: patch review -> resolved
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Irit Katriel]

Irit Katriel  added the comment:

Can this be closed now or is there anything else to do?

--
nosy: +iritkatriel
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[miss-islington]

miss-islington  added the comment:


New changeset 0663ca17f5535178c083c6734fa52e40bd2db2de by Miss Islington (bot) 
in branch '3.9':
bpo-44439: _ZipWriteFile.write() handle buffer protocol correctly (GH-29468)
https://github.com/python/cpython/commit/0663ca17f5535178c083c6734fa52e40bd2db2de


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[miss-islington]

miss-islington  added the comment:


New changeset 21c5b3f73fb11fb0d3239971f72e8f0574a07245 by Miss Islington (bot) 
in branch '3.10':
bpo-44439: _ZipWriteFile.write() handle buffer protocol correctly (GH-29468)
https://github.com/python/cpython/commit/21c5b3f73fb11fb0d3239971f72e8f0574a07245


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[miss-islington]

Change by miss-islington :


--
pull_requests: +29868
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/31755

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[miss-islington]

Change by miss-islington :


--
pull_requests: +29869
pull_request: https://github.com/python/cpython/pull/31756

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 36dd7396fcd26d8bf9919d536d05d7000becbe5b by Ma Lin in branch 
'main':
bpo-44439: _ZipWriteFile.write() handle buffer protocol correctly (GH-29468)
https://github.com/python/cpython/commit/36dd7396fcd26d8bf9919d536d05d7000becbe5b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Ma Lin]

Ma Lin  added the comment:

Serhiy Storchaka:

Sorry, I found `zipfile` module also has this bug, fixed in PR29468.

This bug was reported & fixed by GitHub user `marcoffee` firstly, so I list him 
as a co-author, his work:
https://github.com/animalize/pyzstd/issues/4

The second commit fixes an omission of issue41735, a very simple fix, I fix it 
in PR29468 by the way.

--
resolution: fixed -> later
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Ma Lin]

Change by Ma Lin :


--
pull_requests: +27721
pull_request: https://github.com/python/cpython/pull/29468

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 01858fbe31e8e0185edfbd3f10172f7c61391c9d by Miss Islington (bot) 
in branch '3.10':
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly 
(GH-26764) (GH-26845)
https://github.com/python/cpython/commit/01858fbe31e8e0185edfbd3f10172f7c61391c9d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you for your contribution Ma Lin.

--
components: +Library (Lib)
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> behavior
versions: +Python 3.10, Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 8bc26d8c9d092840054f57f9b4620de0d40d8423 by Ma Lin in branch 
'3.9':
bpo-44439: BZ2File.write()/LZMAFile.write() handle length correctly (GH-26846)
https://github.com/python/cpython/commit/8bc26d8c9d092840054f57f9b4620de0d40d8423


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Ma Lin]

Change by Ma Lin :


--
pull_requests: +25427
pull_request: https://github.com/python/cpython/pull/26846

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Christian Heimes]

Change by Christian Heimes :


--
nosy:  -christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset bc6c12c72a9536acc96e7b9355fd69d1083a43c1 by Ma Lin in branch 
'main':
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly 
(GH-26764)
https://github.com/python/cpython/commit/bc6c12c72a9536acc96e7b9355fd69d1083a43c1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 5.0 -> 6.0
pull_requests: +25426
pull_request: https://github.com/python/cpython/pull/26845

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44439] stdlib wrongly uses len() for bytes-like object

[Ma Lin]

Ma Lin  added the comment:

I am checking all the .py files in `Lib` folder.
hmac.py has two len() bugs:
https://github.com/python/cpython/blob/v3.10.0b3/Lib/hmac.py#L212
https://github.com/python/cpython/blob/v3.10.0b3/Lib/hmac.py#L214

I think PR 26764 is prepared, it fixes the len() bugs in bz2.py/lzma.py files.

--
nosy: +christian.heimes
title: PickleBuffer doesn't have __len__ method -> stdlib wrongly uses len() 
for bytes-like object

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com