[issue44611] CPython uses deprecated randomness API

2021-08-04 Thread STINNER Victor


STINNER Victor  added the comment:

Thanks for this change, I like the fact that hCryptProv variable could be 
removed!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-08-04 Thread STINNER Victor


STINNER Victor  added the comment:

Would it be possible to document in os.urandom() documentation that the 
BCryptGenRandom() function is used on Windows with the "system-preferred random 
number generator algorithm"? (I don't think that we should mention the 
BCRYPT_USE_SYSTEM_PREFERRED_RNG constant.)

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-24 Thread Łukasz Langa

Łukasz Langa  added the comment:


New changeset 4463fa2fa111e03f7ec47e6e9d433104aa943605 by Dong-hee Na in branch 
'main':
bpo-44611: Update docs for os and whatsnew 3.11 (#27314)
https://github.com/python/cpython/commit/4463fa2fa111e03f7ec47e6e9d433104aa943605


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-23 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +25859
pull_request: https://github.com/python/cpython/pull/27314

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-23 Thread Dong-hee Na


Change by Dong-hee Na :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-23 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset 906fe47083bc9ab7ed2b70c99c1b0daad021f126 by Dong-hee Na in branch 
'main':
bpo-44611: Use BCryptGenRandom instead of CryptGenRandom on Windows (GH-27168)
https://github.com/python/cpython/commit/906fe47083bc9ab7ed2b70c99c1b0daad021f126


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-20 Thread Dong-hee Na


Dong-hee Na  added the comment:

@tim.peters

Can you please take a look at GH-27168?
I would like to get your review before merging this PR :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-16 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests:  -25742

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-16 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +25742
pull_request: https://github.com/python/cpython/pull/27206

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-16 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests:  -25740

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-16 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +25740
pull_request: https://github.com/python/cpython/pull/27206

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-15 Thread Dong-hee Na


Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +25704
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/27168

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-15 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-12 Thread Dan Stromberg


Dan Stromberg  added the comment:

Yes, cng-portal.

On Mon, Jul 12, 2021 at 3:24 PM Thomas Grainger 
wrote:

>
> Thomas Grainger  added the comment:
>
> https://docs.microsoft.com/en-us/windows/win32/seccng/cng-portal ?
>
> --
> nosy: +graingert
>
> ___
> Python tracker 
> 
> ___
>

-- 

Dan Stromberg | Senior Software Engineer

Mobile +1.949.342.6502



** This email is confidential and is intended for the recipient(s)
addressed herein **

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-12 Thread Thomas Grainger


Thomas Grainger  added the comment:

https://docs.microsoft.com/en-us/windows/win32/seccng/cng-portal ?

--
nosy: +graingert

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-12 Thread Tim Peters


Tim Peters  added the comment:

Dan, the Microsoft URL in your message gives a 404 for me. Did you perhaps mean 
to end it with "cng-portal" (instead of "cng-por")?

--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44611] CPython uses deprecated randomness API

2021-07-12 Thread Dan Stromberg


New submission from Dan Stromberg :

CPython 3.9 uses CryptGenRandom(), which has been deprecated by Microsoft.

I'm told the randomness produced by CryptGenRandom() is fine, but Microsoft has 
introduced a newer API for getting randomness.

For these reasons, Python/bootstrap_hash.c should be updated to use 
https://docs.microsoft.com/en-us/windows/win32/seccng/cng-por , but it is not 
urgent, and is not needed in older versions of CPython.

Also the documentation that references CryptGenRandom() should be updated, EG: 
https://docs.python.org/3/library/os.html#os.urandom

--
components: Windows
messages: 397339
nosy: paul.moore, steve.dower, strombrg, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: CPython uses deprecated randomness API
type: enhancement
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com