[issue44631] Refactoring the repr() of the _Environ class (os module)

[Łukasz Langa]

Change by Łukasz Langa :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44631] Refactoring the repr() of the _Environ class (os module)

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 85fa3b6b7c11897732fedc443db0e4e8e380c8f8 by Leonardo Freua in 
branch 'main':
bpo-44631: Make the repr() of the _Environ class more readable. (#27128)
https://github.com/python/cpython/commit/85fa3b6b7c11897732fedc443db0e4e8e380c8f8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44631] Refactoring the repr() of the _Environ class (os module)

[Éric Araujo]

Éric Araujo  added the comment:

Hello!  I’ve seen your name on a few recent tickets, thanks for contributing 
and welcome here! 

In general, the CPython project doesn’t do esthetic code changes for their own 
sake.  Not all code is changed from %-formatting when format is added, not all 
code using format changes to f-string, and code that works is left alone.  Each 
change merged takes resources to run tests, build packages, update clones; it 
changes the history of the files touched (which is important when investigating 
a bug months or years later); it takes time to review (pre or post-commit); it 
has the opportunity of introducing bugs.  Therefore, in the absence of a bug to 
fix or a new feature that is made easier by prior changes, I think this should 
be closed as not a bug.

--
nosy: +eric.araujo, lukasz.langa
versions:  -Python 3.10, Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44631] Refactoring the repr() of the _Environ class (os module)

[Leonardo Freua]

Change by Leonardo Freua :


--
keywords: +patch
pull_requests: +25671
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/27128

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44631] Refactoring the repr() of the _Environ class (os module)

[Leonardo Freua]

New submission from Leonardo Freua :

Currently, the repr() code of the _Environ class does many things in a bunched 
way, making it difficult to read and difficult to determine the result returned 
by the method.

Therefore, I propose an adjustment in the code to make it more readable, as 
well as your test.

--
components: Library (Lib)
messages: 397448
nosy: Leonardofreua
priority: normal
severity: normal
status: open
title: Refactoring the repr() of the _Environ class (os module)
type: enhancement
versions: Python 3.10, Python 3.11, Python 3.6, Python 3.7, Python 3.8, Python 
3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com