[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 9ef1843892500e209afe5d916db26ecdbccd5e62 by Łukasz Langa in 
branch '3.9':
bpo-44756: Remove misleading NEWS entries of a change that was reverted before 
release (GH-28075)
https://github.com/python/cpython/commit/9ef1843892500e209afe5d916db26ecdbccd5e62


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 5246dbc2a12bf8e64e18efee2fdce02a350bbf09 by Łukasz Langa in 
branch 'main':
bpo-44756: Remove misleading NEWS entries of a change that was reverted before 
release (GH-28075)
https://github.com/python/cpython/commit/5246dbc2a12bf8e64e18efee2fdce02a350bbf09


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Change by Łukasz Langa :


--
pull_requests: +26519
pull_request: https://github.com/python/cpython/pull/28075

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:

Revert done. Re-closing!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[miss-islington]

miss-islington  added the comment:


New changeset 1e9c9ca570ffe92dc6a60825c2f9c91865129b8f by Miss Islington (bot) 
in branch '3.10':
bpo-44756: [docs] revert automated virtual environment creation on `make html` 
(GH-27635)
https://github.com/python/cpython/commit/1e9c9ca570ffe92dc6a60825c2f9c91865129b8f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 91f6d386691c060dfaa870d74b370e9c10eb8cd8 by Miss Islington (bot) 
in branch '3.9':
bpo-44756: [docs] revert automated virtual environment creation on `make html` 
(GH-27635) (GH-27636)
https://github.com/python/cpython/commit/91f6d386691c060dfaa870d74b370e9c10eb8cd8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[miss-islington]

Change by miss-islington :


--
pull_requests: +26131
pull_request: https://github.com/python/cpython/pull/27637

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[miss-islington]

Change by miss-islington :


--
pull_requests: +26130
pull_request: https://github.com/python/cpython/pull/27636

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 55fa87b1ef46bbb9db7612b2dc2dd7fb039d9bc3 by Łukasz Langa in 
branch 'main':
bpo-44756: [docs] revert automated virtual environment creation on `make html` 
(GH-27635)
https://github.com/python/cpython/commit/55fa87b1ef46bbb9db7612b2dc2dd7fb039d9bc3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Change by Łukasz Langa :


--
pull_requests: +26129
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/27635

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Ned Deily]

Change by Ned Deily :


--
versions: +Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Ned Deily]

Ned Deily  added the comment:

There was a previous attempt at adding a dependency on venv that ended up being 
reverted (Issue30487 and 122fc136b34e11906466851e77bb6959946467ee0). Over the 
years we have had a number of iterations of tweaking Doc/Makefile to balance 
ease of use (by providing the venv) with those of more advanced users who build 
docs as part of their automated processeses. I think what we had prior to this 
most recent change worked reasonably well for all. The previous process is 
clearly documented, for example in the Dev Guide 
(https://devguide.python.org/documenting/?highlight=venv#building-the-documentation)
 and does not strike me as very onerous. I appreciate the motivation behind 
this change but I really think there isn't a problem here that needs to be 
solved and I would support reverting the change for 3.9 and 3.10 and *perhaps* 
reconsider something for 3.11.

--
nosy: +ned.deily
priority: normal -> release blocker
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Note this issue has impacted negatively the release process of 3.10.0rc1:

https://bugs.python.org/issue44823

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Petr Viktorin]

Petr Viktorin  added the comment:

I've sent a mail to python-dev: 
https://mail.python.org/archives/list/python-...@python.org/thread/MGPNI7OSA7UXNOTVDVW2I2GUMXV25FRS/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Petr Viktorin]

Petr Viktorin  added the comment:

The issue this (or lack of communication about it) caused in rc1 is tracked in 
https://bugs.python.org/issue44823

> @petr.viktorin a whatsnew entry was added, what more notice could have been 
> provided?

Ideally, the python-dev mailing list (or Discourse).

> pip install sphinx blurb python-docs-theme
> If running that is ever unsafe, we have big problems!

Who is "we"?
We do have big problems. Anyone who can upload wheels for sphinx blurb 
python-docs-theme or any of their dependencies (or anyone who has their 
credentials) can now easily put code on machines of CPython developers.

For example, PyPI doesn't guarantee that wheels correspond to sources. 
"Markupsafe" is particularly dangerous because the wheels are platform-specific 
and have compiled code, so tampering is nearly undetectable. (But if another 
dependency starts using platform-specific wheels, I don't think anyone would 
notice.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Miro Hrončok]

Miro Hrončok  added the comment:

The 3.10.0rc1 source tarballs contain the Docs/venv directory populated with 
pablogsal's venv: issue44824

--
nosy: +hroncok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Jack DeVries]

Jack DeVries  added the comment:

Actually, I tested out that idea 
(https://github.com/python/cpython/compare/main...jdevries3133:bpo-44756-doc-make),
 and I don't think its as nice of a solution. I think it is valuable for new 
contributors to be able to type "make html" and have it work. Look at how much 
the change simplifies the README for new contributors to setup their 
documentation build toolchain. Then, look at how many ``docs@python`` open 
issues there are. We need documentation contributors, and there is value in 
simplifying the process for them.

Additionally, this is the extent of the "downloading code from the internet and 
running it" that occurs::

pip install -U pip setuptools
pip install sphynx blurb python-docs-theme

If running that is ever unsafe, we have big problems!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Jack DeVries]

Jack DeVries  added the comment:

@petr.viktorin a whatsnew entry was added, what more notice could have been 
provided?

I have an idea for an alternative that might be better. What if ``make clean`` 
deletes and restores the venv only if it already existed in the first place?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Petr Viktorin]

Petr Viktorin  added the comment:

I'm one of those who disagree with "make html" suddenly downloading code from 
the internet and running it, but I guess I'm in a minority. I'll switch to 
using `sphinx-build` directly.

Still, I'd have appreciated a heads-up notice.

--
nosy: +petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset fd2c2465d49a8bcb32eeda82d694eed48e57ba79 by Miss Islington (bot) 
in branch '3.9':
bpo-44756: in ./Doc, `make build` depends on `make html` (GH-27403) (GH-27411)
https://github.com/python/cpython/commit/fd2c2465d49a8bcb32eeda82d694eed48e57ba79


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:

Thanks, Jack! ✨  ✨

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset f113195ac85d58bdde348b5bb74eb97e6485e408 by Miss Islington (bot) 
in branch '3.10':
bpo-44756: in ./Doc, `make build` depends on `make html` (GH-27403) (GH-27410)
https://github.com/python/cpython/commit/f113195ac85d58bdde348b5bb74eb97e6485e408


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +25943
pull_request: https://github.com/python/cpython/pull/27410

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset d22c876d5ac5fa464337d2e82654b8d87a83cb1b by Jack DeVries in 
branch 'main':
bpo-44756: in ./Doc, `make build` depends on `make html` (#27403)
https://github.com/python/cpython/commit/d22c876d5ac5fa464337d2e82654b8d87a83cb1b


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[miss-islington]

Change by miss-islington :


--
pull_requests: +25944
pull_request: https://github.com/python/cpython/pull/27411

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Jack DeVries]

Change by Jack DeVries :


--
keywords: +patch
pull_requests: +25936
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/27403

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

[Jack DeVries]

New submission from Jack DeVries :

In Doc/Makefile, all of the build rules should be dependent on the existence of 
a virtual environment. I could see this being controversial, because folks who 
have these tools installed elsewhere might prefer not to have a venv made for 
them, but my personal workflow is to strive to keep my system site-packages 
folder as empty as possible and to use virtual environments frequently. In any 
case, I'm interested to hear what we think.

Momentarily, I will attach a PR where I went ahead and made these changes. Here 
is a summary of the changes:

- venv rule is now conditional, and only does anything if $VENVDIR does 
  not exist
- add rule "clean-venv". This can be removed – what do you all think?
- build rule is dependent on venv
- as a result, rules dependent on build are dependent on venv
  - html
  - latex
  - etc.
- update Doc/README.rst appropriately. Now users only need to type 
  ``make html`` – nice!

Let me know what you think. I may have a blind spot to others' workflows! Also, 
I'm not a Windows user, so I have no insight as to whether ``make.bat`` needs 
to be updated as well.

--
assignee: docs@python
components: Demos and Tools, Documentation
messages: 398344
nosy: docs@python, jack__d
priority: normal
severity: normal
status: open
title: In ./Doc, "make html" and "make build" should depend on "make venv"
type: enhancement
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com