[issue45138] [sqlite3] expand bound values in traced statements when possible

[miss-islington]

miss-islington  added the comment:


New changeset e801e88744f34508aa338f9f7f3f3baee012f813 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45138: Revert GH-28240: Expand traced SQL statements (GH-31788)
https://github.com/python/cpython/commit/e801e88744f34508aa338f9f7f3f3baee012f813


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45138] [sqlite3] expand bound values in traced statements when possible

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +29892
pull_request: https://github.com/python/cpython/pull/31788

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45138] [sqlite3] expand bound values in traced statements when possible

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +29888
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/31783

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45138] [sqlite3] expand bound values in traced statements when possible

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Ah, one of my very first contributions, bpo-40318, comes back to haunt me:

In bpo-40318, we migrated from the old SQLite trace API (sqlite3_trace) to 
SQLite trace v2 API (sqlite3_trace_v2). GH-19581, which introduced this change, 
introduced a bug: the old trace API _implicitly_ expanded bound parameters; the 
new trace API does not. However, there was no tests for this behaviour, so the 
regression was unnoticed[^1].

So, this bpo is actually a bug fix; not a feature. It should be backported to 
3.10, which contains the regression.

I'm preparing a fix for GH-28240, and I'll prepare a 3.10 backport including 
both GH-2840 and its upcoming fix.


[^1]: There has been no bug reports regarding this change in behaviour, so it 
seems to have gone under most people's radar.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45138] [sqlite3] expand bound values in traced statements when possible

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Reopening bco. broken buildbots.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45138] [sqlite3] expand bound values in traced statements when possible

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:

Thanks for the contribution!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45138] [sqlite3] expand bound values in traced statements when possible

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:


New changeset d1777515f9f53b452a4231d68196a7c0e5deb879 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45138: Expand traced SQL statements in `sqlite3` trace callback (GH-28240)
https://github.com/python/cpython/commit/d1777515f9f53b452a4231d68196a7c0e5deb879


--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45138] [sqlite3] expand bound values in traced statements when possible

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
title: [sqlite3] expand bound values in traced statements if possible -> 
[sqlite3] expand bound values in traced statements when possible

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com