[issue45173] Remove configparser deprecations

[miss-islington]

miss-islington  added the comment:


New changeset ba4d79af32b6bb8378cb7003f67d6c4d413fbe89 by Hugo van Kemenade in 
branch '3.10':
[3.10] bpo-45173: Note configparser deprecations will be removed in 3.12 
(GH-31084)
https://github.com/python/cpython/commit/ba4d79af32b6bb8378cb7003f67d6c4d413fbe89


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

Change by Hugo van Kemenade :


--
pull_requests: +29268
pull_request: https://github.com/python/cpython/pull/31084

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset e8659b47dece5a272111c0af5e340c364a9f807b by Hugo van Kemenade in 
branch 'main':
bpo-45173: Keep configparser deprecations until Python 3.12 (GH-30952)
https://github.com/python/cpython/commit/e8659b47dece5a272111c0af5e340c364a9f807b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

Hugo van Kemenade  added the comment:

Sure, please see https://bugs.python.org/issue46607.

I've rebased GH-30927 to use the new issue number.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

Change by Hugo van Kemenade :


--
pull_requests:  -29106

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[STINNER Victor]

STINNER Victor  added the comment:

Currently, the issue title is "Remove configparser deprecations".

GH-30927 doesn't remove deprecated functions, but adds new warnings. It's 
really confusing to make this change as part of this issue.

Can you please create a new issue for GH-30927 "bpo-45173: Add 
DeprecationWarning to LegacyInterpolation"? If it's removed, it's not going to 
be removed before Python 3.13, so it's not directly related to this issue. By 
the way, it would be nice explain the rationale for removing it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[STINNER Victor]

STINNER Victor  added the comment:

> Searching 4,764 sdists from the top 5,000 PyPI packages, these 13 contain 
> "LegacyInterpolation"

Other removed symbols are causing troubles, like SafeConfigParser.

Example of Fedora bz #2025600: mom fails to build with Python 3.11: 
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'.

=> https://bugzilla.redhat.com/show_bug.cgi?id=2025600

Another example: python-iniparse fails to build with Python 3.11: 
AttributeError: 'RawConfigParser' object has no attribute 'readfp'

https://bugzilla.redhat.com/show_bug.cgi?id=2019017

You can try to unfold 
https://bugzilla.redhat.com/buglist.cgi?bug_id=2016048&bug_id_type=anddependson&format=tvp
 and search for "configparser".

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

Change by Hugo van Kemenade :


--
pull_requests: +29131
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30952

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Gregory P. Smith]

Gregory P. Smith  added the comment:

Per 
https://mail.python.org/archives/list/python-...@python.org/thread/GJTREADEXYAETECE5JDTPYWK4WMTKYGR/
 we want to revert 
https://github.com/python/cpython/commit/1fc41ae8709e20d741bd86c2345173688a5e84b0
 for 3.11 to avoid causing pain.

per that thread and 
https://discuss.python.org/t/experience-with-python-3-11-in-fedora/12911 it 
sounds like you may be on top of filing upstream issues/PRs to get OSS projects 
to stop using the deprecated APIs.  great!  that should help this stick in 3.12.

as the commit removed several things at once, I suggest a full rollback, and 
smaller PRs for individual things if your upstream python project testing 
reveals things that nobody appears to be depending on.

--
nosy: +gregory.p.smith
priority: normal -> deferred blocker
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

Change by Hugo van Kemenade :


--
pull_requests: +29106
pull_request: https://github.com/python/cpython/pull/30927

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

Hugo van Kemenade  added the comment:

Searching 4,764 sdists from the top 5,000 PyPI packages, these 13 contain 
"LegacyInterpolation":

configparser-5.1.0.tar.gz
configparser2-4.0.0.tar.gz
eth_abi-2.1.1.tar.gz
eth-account-0.5.6.tar.gz
eth-hash-0.3.2.tar.gz
eth-utils-1.10.0.tar.gz
hexbytes-0.2.2.tar.gz
jedi-0.18.1.tar.gz
magicinvoke-2.4.5.tar.gz
mypy-0.910.tar.gz
pytype-2021.11.12.tar.gz
web.py-0.62.tar.gz
webcolors-1.11.1.tar.gz


The first two are stdlib backports: configparser is active and configparser2 
was last updated in 2015:

configparser-5.1.0/src/backports/configparser/__init__.py:
"LegacyInterpolation",
configparser-5.1.0/src/backports/configparser/__init__.py:class 
LegacyInterpolation(Interpolation):
configparser-5.1.0/src/configparser.py:"LegacyInterpolation",
configparser-5.1.0/src/configparser.py:LegacyInterpolation,
configparser-5.1.0/src/test_configparser.py:elif 
isinstance(self.interpolation, configparser.LegacyInterpolation):
configparser-5.1.0/src/test_configparser.py:elif 
isinstance(self.interpolation, configparser.LegacyInterpolation):
configparser-5.1.0/src/test_configparser.py:elif 
isinstance(self.interpolation, configparser.LegacyInterpolation):
configparser-5.1.0/src/test_configparser.py:interpolation = 
configparser.LegacyInterpolation()
configparser-5.1.0/src/test_configparser.py:class 
ConfigParserTestCaseLegacyInterpolation(ConfigParserTestCase, 
unittest.TestCase):

configparser2-4.0.0/src/backports/configparser2/__init__.py:class 
LegacyInterpolation(Interpolation):
configparser2-4.0.0/src/configparser2.py:LegacyInterpolation,


The others are all configparser.pyi typeshed stub files:

eth_abi-2.1.1/venv/lib/python3.6/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth_abi-2.1.1/venv/lib64/python3.6/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-account-0.5.6/venv-py3.8/lib/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-account-0.5.6/venv-py3.8/lib/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-account-0.5.6/venv-py3.8/lib64/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-account-0.5.6/venv-py3.8/lib64/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-account-0.5.6/venv/lib/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-account-0.5.6/venv/lib/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-account-0.5.6/venv/lib64/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-account-0.5.6/venv/lib64/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-hash-0.3.2/venv-py3.8/lib/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-hash-0.3.2/venv-py3.8/lib/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-hash-0.3.2/venv-py3.8/lib64/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-hash-0.3.2/venv-py3.8/lib64/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-hash-0.3.2/venv/lib/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-hash-0.3.2/venv/lib/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-hash-0.3.2/venv/lib64/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-hash-0.3.2/venv/lib64/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-utils-1.10.0/venv-py3.8/lib/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-utils-1.10.0/venv-py3.8/lib/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-utils-1.10.0/venv-py3.8/lib64/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-utils-1.10.0/venv-py3.8/lib64/python3.8/site-packages/mypy/typeshed/stdlib/3/configparser.pyi:class
 LegacyInterpolation(Interpolation): ...
eth-utils-1.10.0/venv/lib/python3.8/site-packages/jedi/third_party/typeshed/stdlib/3/con

[issue45173] Remove configparser deprecations

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 1fc41ae8709e20d741bd86c2345173688a5e84b0 by Hugo van Kemenade in 
branch 'main':
bpo-45173 Remove configparser deprecations (GH-28292)
https://github.com/python/cpython/commit/1fc41ae8709e20d741bd86c2345173688a5e84b0


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

Hugo van Kemenade  added the comment:

Also, the LegacyInterpolation class is deprecated since Python 3.2 but with no 
DeprecationWarning.

A quick sampling of GitHub results shows only copies of CPython's 
configparser.py and test_configparser.py

https://github.com/search?l=Python&p=1&q=LegacyInterpolation+extension%3Apy+language%3APython+language%3APython&ref=advsearch&type=Code

No use found in the top 200 PyPI packages.

Is it safe to remove now, or should it raise DeprecationWarning for a couple of 
releases first?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

Change by Hugo van Kemenade :


--
keywords: +patch
pull_requests: +26708
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/28292

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45173] Remove configparser deprecations

[Hugo van Kemenade]

New submission from Hugo van Kemenade :

In the configparser module, these have been deprecated since Python 3.2:

* the SafeConfigParser class,
* the filename property of the ParsingError class,
* the readfp method of the ConfigParser class,

They can be removed in Python 3.11.

--
components: Library (Lib)
messages: 401644
nosy: hugovk
priority: normal
severity: normal
status: open
title: Remove configparser deprecations
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com