[issue45269] c_make_encoder() has uncovered error: "argument 1 must be dict or None"

[Łukasz Langa]

Łukasz Langa  added the comment:

Thanks, Nikita! ✨  ✨

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45269] c_make_encoder() has uncovered error: "argument 1 must be dict or None"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 1cb17be3e6a4d94629606a613acd07f78d50348b by Miss Islington (bot) 
in branch '3.10':
bpo-45269: test wrong `markers` type to `c_make_encoder` (GH-28540) (GH-28609)
https://github.com/python/cpython/commit/1cb17be3e6a4d94629606a613acd07f78d50348b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45269] c_make_encoder() has uncovered error: "argument 1 must be dict or None"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset c6b5ceae3475d7782ed88f4e54bdb2232a8eb088 by Miss Islington (bot) 
in branch '3.9':
bpo-45269: test wrong `markers` type to `c_make_encoder` (GH-28540) (GH-28610)
https://github.com/python/cpython/commit/c6b5ceae3475d7782ed88f4e54bdb2232a8eb088


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45269] c_make_encoder() has uncovered error: "argument 1 must be dict or None"

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset e046aabbe386fdf32bae6ffb7fae5ce479fd10c6 by Nikita Sobolev in 
branch 'main':
bpo-45269: test wrong `markers` type to `c_make_encoder` (GH-28540)
https://github.com/python/cpython/commit/e046aabbe386fdf32bae6ffb7fae5ce479fd10c6


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45269] c_make_encoder() has uncovered error: "argument 1 must be dict or None"

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +26980
pull_request: https://github.com/python/cpython/pull/28609

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45269] c_make_encoder() has uncovered error: "argument 1 must be dict or None"

[miss-islington]

Change by miss-islington :


--
pull_requests: +26981
pull_request: https://github.com/python/cpython/pull/28610

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45269] c_make_encoder() has uncovered error: "argument 1 must be dict or None"

[Nikita Sobolev]

Change by Nikita Sobolev :


--
keywords: +patch
pull_requests: +26924
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/28540

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45269] c_make_encoder() has uncovered error: "argument 1 must be dict or None"

[Nikita Sobolev]

New submission from Nikita Sobolev :

Looks like we never test error that `markers` are limited to `None` and `dict` 
types. Here: 
https://github.com/python/cpython/blob/main/Modules/_json.c#L1252-L1255

Coverage report: 
https://app.codecov.io/gh/python/cpython/blob/master/Modules/_json.c line: 1252

I will submit a unit test for it today.

Related: https://bugs.python.org/issue6986

--
components: Tests
messages: 402482
nosy: sobolevn
priority: normal
severity: normal
status: open
title: c_make_encoder() has uncovered error: "argument 1 must be dict or None"
type: behavior
versions: Python 3.10, Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com