[issue45629] Tools/freeze needs tests in the test suite.

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 8726067ace98a27557e9fdf1a8e1c509c37cfcfc by Gregory P. Smith in 
branch 'main':
bpo-45629: Improve test.support.skip_if_buildbot (GH-31094)
https://github.com/python/cpython/commit/8726067ace98a27557e9fdf1a8e1c509c37cfcfc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45629] Tools/freeze needs tests in the test suite.

[Gregory P. Smith]

Change by Gregory P. Smith :


--
nosy: +gregory.p.smith
nosy_count: 2.0 -> 3.0
pull_requests: +29280
pull_request: https://github.com/python/cpython/pull/31094

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45629] Tools/freeze needs tests in the test suite.

[Eric Snow]

Change by Eric Snow :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45629] Tools/freeze needs tests in the test suite.

[Eric Snow]

Eric Snow  added the comment:


New changeset 13d9205f4057f80a25d410ad123876dc60cd by Eric Snow in branch 
'main':
bpo-45629: Add a test for the "freeze" tool. (gh-29222)
https://github.com/python/cpython/commit/13d9205f4057f80a25d410ad123876dc60cd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45629] Tools/freeze needs tests in the test suite.

[Eric Snow]

Change by Eric Snow :


--
keywords: +patch
pull_requests: +27506
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/29222

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45629] Tools/freeze needs tests in the test suite.

[Eric Snow]

New submission from Eric Snow :

I found that Tools/freeze doesn't get tested.  It has a "test" directory but 
it's more of a rudimentary sanity check that must be run manually.  Since the 
tool isn't tested through our test suite, there's a high likelihood it can get 
broken without anyone realizing it.  The risk has increased with recent changes 
to frozen modules.  So such tests would be valuable.

The tool requires that Python be installed.  In the context of our test suite, 
this means configuring with a temp dir prefix and then re-building.  We must do 
it in a separate directory to avoid affecting other tests.

I'm planning on adding a test that does the following:

1. create a temp dir (TMPDIR)
2. copy the repo to TMPDIR/cpython
3. run configure there with --prefix=TMPDIR/python-installation
4. run make -j
5. run make install -j
6. write a simple script to TMPDIR/app.py
7. run the "freeze" tool on it, with minimal options
8. run the frozen app and verify it worked

Note that there needs to be enough disk space for all that (which not all 
buildbots have).  Also, the test will be relatively slow due to having to 
re-build.

There aren't any other tests that re-build Python or the like, so I'm a little 
hesitant to set precedent.  Perhaps that's why there weren't any tests already. 
 However, I don't see any significant reasons to not add the test (as long as 
it doesn't lead to spurious failures).

--
assignee: eric.snow
components: Demos and Tools
messages: 405105
nosy: eric.snow, lemburg
priority: normal
severity: normal
stage: test needed
status: open
title: Tools/freeze needs tests in the test suite.
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com