[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread Tal Einat


Tal Einat  added the comment:

Good to know Eric, will do!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread Eric V. Smith


Eric V. Smith  added the comment:

Thanks for committing this, @taleinat. But next time, if it's assigned to me, 
I'd like to review it first. Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread Tal Einat


Tal Einat  added the comment:

Thanks for the report and the PR, Zsolt!

--
nosy:  -miss-islington
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread miss-islington


miss-islington  added the comment:


New changeset cd95033d9c27d6c541dfd774b4c5eab4a70a23ab by Miss Islington (bot) 
in branch '3.9':
bpo-46290: Fix parameter names in dataclasses docs (GH-30450)
https://github.com/python/cpython/commit/cd95033d9c27d6c541dfd774b4c5eab4a70a23ab


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread miss-islington


miss-islington  added the comment:


New changeset 8bef658668bac923166ae160c79720aed5f3b712 by Miss Islington (bot) 
in branch '3.10':
bpo-46290: Fix parameter names in dataclasses docs (GH-30450)
https://github.com/python/cpython/commit/8bef658668bac923166ae160c79720aed5f3b712


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread miss-islington


Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +28686
pull_request: https://github.com/python/cpython/pull/30482

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread miss-islington


Change by miss-islington :


--
pull_requests: +28687
pull_request: https://github.com/python/cpython/pull/30483

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread Tal Einat


Tal Einat  added the comment:


New changeset ef5376e69e72fa922d7f1b3df47b99d3576f9df1 by Zsolt Dollenstein in 
branch 'main':
bpo-46290: Fix parameter names in dataclasses docs (GH-30450)
https://github.com/python/cpython/commit/ef5376e69e72fa922d7f1b3df47b99d3576f9df1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-08 Thread Tal Einat


Tal Einat  added the comment:

Indeed, the argument name in the code is "obj", and in 3 of those 4 functions 
it is a normal (positional or keyword) argument, so the name is important.

--
assignee: eric.smith -> taleinat
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-07 Thread Eric V. Smith


Change by Eric V. Smith :


--
assignee: docs@python -> eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-07 Thread Alex Waygood


Change by Alex Waygood :


--
nosy: +eric.smith
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-07 Thread Zsolt Dollenstein


Change by Zsolt Dollenstein :


--
keywords: +patch
pull_requests: +28655
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30450

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46290] Parameter names are inaccurate in dataclasses docs

2022-01-07 Thread Zsolt Dollenstein


New submission from Zsolt Dollenstein :

Parameter names for `asdict`, `astuple`, `is_dataclass`, and `replace` are 
incorrect in the docs. The first parameter for all these is `obj`.

--
assignee: docs@python
components: Documentation
messages: 409957
nosy: docs@python, zsol
priority: normal
severity: normal
status: open
title: Parameter names are inaccurate in dataclasses docs
versions: Python 3.10, Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com